Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GTFS GraphQL API by default, remove the word "legacy" from its documentation #5202

Merged

Conversation

leonardehrenfried
Copy link
Member

@leonardehrenfried leonardehrenfried commented Jun 19, 2023

Summary

It's finally happening! This removes the word legacy from the API that is now going to be known as GTFS GraphQL API in the documentation.

It also renames its feature switch to GtfsGraphQlApi and enables it by default.

Issue

Relates to #4828

@leonardehrenfried leonardehrenfried marked this pull request as ready for review June 19, 2023 12:42
@leonardehrenfried leonardehrenfried requested a review from a team as a code owner June 19, 2023 12:42
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: +0.01 🎉

Comparison is base (e6436fa) 65.42% compared to head (df112cd) 65.44%.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #5202      +/-   ##
=============================================
+ Coverage      65.42%   65.44%   +0.01%     
- Complexity     14477    14491      +14     
=============================================
  Files           1755     1754       -1     
  Lines          67987    68022      +35     
  Branches        7231     7238       +7     
=============================================
+ Hits           44482    44515      +33     
- Misses         21035    21042       +7     
+ Partials        2470     2465       -5     
Impacted Files Coverage Δ
...pentripplanner/api/configuration/APIEndpoints.java 0.00% <0.00%> (ø)
...r/standalone/config/routerconfig/ServerConfig.java 100.00% <ø> (ø)
...ntripplanner/framework/application/OTPFeature.java 87.87% <100.00%> (ø)
...g/opentripplanner/standalone/config/OtpConfig.java 94.11% <100.00%> (ø)
...tripplanner/standalone/config/OtpConfigLoader.java 76.66% <100.00%> (+0.80%) ⬆️

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@leonardehrenfried leonardehrenfried changed the title Enable GTFS GraphQL API by deafult, remove the word "legacy" from its documentation Enable GTFS GraphQL API by default, remove the word "legacy" from its documentation Jun 20, 2023
@leonardehrenfried leonardehrenfried requested review from optionsome, jtorin and vpaturet and removed request for optionsome June 20, 2023 08:44
docs/Apis-Data-Sources.md Outdated Show resolved Hide resolved
docs/sandbox/GtfsGraphQlApi.md Outdated Show resolved Hide resolved
docs/sandbox/TransmodelApi.md Outdated Show resolved Hide resolved
Co-authored-by: Johan Torin <jtorin@users.noreply.github.com>
@leonardehrenfried leonardehrenfried merged commit d48a733 into opentripplanner:dev-2.x Jun 22, 2023
5 checks passed
@leonardehrenfried leonardehrenfried deleted the remove-legacy branch June 22, 2023 08:37
t2gran pushed a commit that referenced this pull request Jun 22, 2023
@t2gran t2gran added this to the 2.4 (next release) milestone Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants