Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filtering by submode #5261

Merged
merged 1 commit into from Aug 1, 2023

Conversation

vpaturet
Copy link
Contributor

Summary

As reported in #5255, filtering by submode does not work in the Transmodel API.
This PR fixes the logic for the special case where an exclusion filter (ex: banned authorities) is used together with a submode filter.

Issue

Closes #5255

Unit tests

Added unit tests.

Documentation

No

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage: 25.00% and project coverage change: +0.02% 🎉

Comparison is base (cca59ff) 65.89% compared to head (481ced9) 65.91%.

❗ Current head 481ced9 differs from pull request most recent head cd24938. Consider uploading reports for the commit cd24938 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #5261      +/-   ##
=============================================
+ Coverage      65.89%   65.91%   +0.02%     
- Complexity     14781    14789       +8     
=============================================
  Files           1770     1770              
  Lines          68680    68683       +3     
  Branches        7276     7278       +2     
=============================================
+ Hits           45259    45275      +16     
+ Misses         20935    20922      -13     
  Partials        2486     2486              
Files Changed Coverage Δ
...i/request/request/filter/TransitFilterRequest.java 87.03% <0.00%> (+3.70%) ⬆️
...ting/api/request/request/filter/SelectRequest.java 83.78% <33.33%> (-2.14%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vpaturet vpaturet marked this pull request as ready for review July 26, 2023 07:46
@vpaturet vpaturet requested a review from a team as a code owner July 26, 2023 07:46
@t2gran t2gran added this to the 2.4 (next release) milestone Jul 26, 2023
@t2gran t2gran added the bug label Jul 26, 2023
@vpaturet vpaturet added the Entur test This is currently being tested at Entur label Jul 26, 2023
@vpaturet vpaturet merged commit 24ce710 into opentripplanner:dev-2.x Aug 1, 2023
5 checks passed
t2gran pushed a commit that referenced this pull request Aug 1, 2023
@vpaturet vpaturet deleted the fix_filtering_by_submode branch October 16, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Entur test This is currently being tested at Entur
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in subMode filtering in Transmodel API
3 participants