Fix filtering by submode - #5261
Merged
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5261 +/- ##
=============================================
+ Coverage 65.89% 65.91% +0.02%
- Complexity 14781 14789 +8
=============================================
Files 1770 1770
Lines 68680 68683 +3
Branches 7276 7278 +2
=============================================
+ Hits 45259 45275 +16
+ Misses 20935 20922 -13
Partials 2486 2486
☔ View full report in Codecov by Sentry. |
vpaturet
force-pushed
the
fix_filtering_by_submode
branch
from
July 25, 2023 16:27
481ced9 to
cd24938
Compare
vpaturet
marked this pull request as ready for review
July 26, 2023 07:46
t2gran
approved these changes
Jul 26, 2023
Bartosz-Kruba
approved these changes
Aug 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As reported in #5255, filtering by submode does not work in the Transmodel API.
This PR fixes the logic for the special case where an exclusion filter (ex: banned authorities) is used together with a submode filter.
Issue
Closes #5255
Unit tests
Added unit tests.
Documentation
No