New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pathway id from REST API #5303
Merged
leonardehrenfried
merged 6 commits into
opentripplanner:dev-2.x
from
leonardehrenfried:remove-pathway-id
Aug 24, 2023
Merged
Remove pathway id from REST API #5303
leonardehrenfried
merged 6 commits into
opentripplanner:dev-2.x
from
leonardehrenfried:remove-pathway-id
Aug 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5303 +/- ##
=============================================
+ Coverage 66.08% 66.20% +0.12%
- Complexity 14942 15140 +198
=============================================
Files 1780 1787 +7
Lines 68969 69205 +236
Branches 7287 7346 +59
=============================================
+ Hits 45576 45816 +240
- Misses 20905 20909 +4
+ Partials 2488 2480 -8
☔ View full report in Codecov by Sentry. |
optionsome
previously approved these changes
Aug 21, 2023
t2gran
requested changes
Aug 21, 2023
leonardehrenfried
force-pushed
the
remove-pathway-id
branch
from
August 22, 2023 11:51
24bf53f
to
d1895c6
Compare
leonardehrenfried
force-pushed
the
remove-pathway-id
branch
from
August 22, 2023 11:57
d1895c6
to
56bd810
Compare
t2gran
approved these changes
Aug 22, 2023
vpaturet
approved these changes
Aug 24, 2023
t2gran
pushed a commit
that referenced
this pull request
Aug 24, 2023
leonardehrenfried
pushed a commit
to leonardehrenfried/OpenTripPlanner
that referenced
this pull request
Aug 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The REST API used to expose the ID of the first pathway on a street leg. This is a strange piece of the API that thankfully didn't make it into the GraphQL API.
Because of this, I'm removing it from the API and also do the associated internal clean up so that we don't needlessly pass the ID around.
Lastly, I renamed a few properties in
WalkStep
so they better reflect their meaning.@miles-grant-ibigroup has confirmed that IBI is not using this field.