Transmodel GraphQL API for pass-through searches #5320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtorin
changed the title
jtorin
force-pushed
the
pass-through_graphql
branch
from
501da3e
to
912a212
Compare
jtorin
changed the title
t2gran
reviewed
Sep 14, 2023
src/main/java/org/opentripplanner/routing/api/request/RouteRequest.java
Outdated
Show resolved
Hide resolved
t2gran
reviewed
Sep 14, 2023
src/ext/java/org/opentripplanner/ext/transmodelapi/model/plan/TripQuery.java
Outdated
Show resolved
Hide resolved
jtorin
force-pushed
the
pass-through_graphql
branch
from
912a212
to
02673e9
Compare
jtorin
force-pushed
the
pass-through_graphql
branch
3 times, most recently
from
a1be9ca
to
ac8382b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5320 +/- ##
=============================================
+ Coverage 66.54% 66.57% +0.02%
- Complexity 15256 15273 +17
=============================================
Files 1787 1790 +3
Lines 69300 69367 +67
Branches 7303 7306 +3
=============================================
+ Hits 46117 46181 +64
- Misses 20708 20709 +1
- Partials 2475 2477 +2
☔ View full report in Codecov by Sentry. |
src/main/java/org/opentripplanner/routing/api/request/PassThroughPoint.java
Outdated
Show resolved
Hide resolved
src/ext/java/org/opentripplanner/ext/transmodelapi/model/plan/TripQuery.java
Outdated
Show resolved
Hide resolved
...xt/java/org/opentripplanner/ext/transmodelapi/model/framework/PassThroughPointInputType.java
Outdated
Show resolved
Hide resolved
...xt/java/org/opentripplanner/ext/transmodelapi/model/framework/PassThroughPointInputType.java
Outdated
Show resolved
Hide resolved
t2gran
requested changes
Sep 27, 2023
...xt/java/org/opentripplanner/ext/transmodelapi/model/framework/PassThroughPointInputType.java
Outdated
Show resolved
Hide resolved
src/ext/java/org/opentripplanner/ext/transmodelapi/model/plan/TripQuery.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/raptor/api/request/PassThroughPoint.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/raptor/api/request/PassThroughPoint.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/routing/api/request/PassThroughPoint.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/routing/api/request/PassThroughPoint.java
Show resolved
Hide resolved
|
When you solved the problem with the race condition, please re-request review. |
t2gran
reviewed
Oct 2, 2023
src/main/java/org/opentripplanner/raptor/api/request/PassThroughPoint.java
Outdated
Show resolved
Hide resolved
t2gran
previously approved these changes
Oct 2, 2023
leonardehrenfried
previously approved these changes
Oct 3, 2023
added 3 commits
October 3, 2023 10:01
For use in tests only.
* Each pass-through point can consist of multiple stopplaces, with an optional name for logging and debugging. * Each stopplace is translated to a complex object instance from the given id. With contributions from Bartosz Kruba.
leonardehrenfried
approved these changes
Oct 3, 2023
jtorin
force-pushed
the
pass-through_graphql
branch
from
2eacbbb
to
82fa760
Compare
|
Squashed fixup commits and rebased. Change on squash: |
t2gran
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension to the GraphQL Transmodel API for performing pass-through searches (popularly called via-searches, but that concept name is already taken). Raptor related changes was merged in #5249.
This is associated to issue #4887.