Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New debug client #5334

Merged
merged 73 commits into from Dec 14, 2023
Merged

New debug client #5334

merged 73 commits into from Dec 14, 2023

Conversation

testower
Copy link
Contributor

@testower testower commented Aug 30, 2023

Summary

We want to replace the old OTP UI, nowadays called the "Debug UI". The old UI uses the deprecated REST API, is not maintained and is based on an old tech stack. So, we (OTP Developer meeting) have decided to make a new UI. The new UI will use the Transmodel GraphQL API.

The goal for the UI is to support OTP developers in day to day work with OTP. If you are looking for a UI to deploy as a service to the public we recommend looking at other options. Ask in the gitter chat for the latest and best option for you.

Note: This PR does not replace the old debug client. We will do this in a later PR. There is more work to be done before we want to remove the old one completely.

Issue

Relates to #5330

Unit tests

No tests for the debug client.

Documentation

There is a README in the new source code folder for now.

Changelog

Bumping the serialization version id

No

@t2gran t2gran changed the title New debug client (draft) New debug client Aug 30, 2023
@t2gran t2gran added improvement OTP Debug UI The OTP bundled client labels Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (79d1cbc) 66.27% compared to head (2dbaa8b) 67.24%.
Report is 1110 commits behind head on dev-2.x.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #5334      +/-   ##
=============================================
+ Coverage      66.27%   67.24%   +0.97%     
- Complexity     15171    16084     +913     
=============================================
  Files           1789     1852      +63     
  Lines          69275    70970    +1695     
  Branches        7351     7399      +48     
=============================================
+ Hits           45910    47724    +1814     
+ Misses         20881    20781     -100     
+ Partials        2484     2465      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@testower testower force-pushed the debug-client-next branch 2 times, most recently from 400f5b7 to 2ec2dad Compare August 30, 2023 14:38
@testower
Copy link
Contributor Author

testower commented Sep 12, 2023

It doesn't show in the check list below 👇 but I added a temporary workflow for verifying the frontend build (linter, formatter, typescript compiler and vite build), until we decide where it should live permanently.

https://github.com/entur/OpenTripPlanner/actions/workflows/client-build.yml

@t2gran t2gran added this to the 2.5 (next release) milestone Sep 13, 2023
@testower testower marked this pull request as ready for review November 24, 2023 13:22
@testower testower requested a review from a team as a code owner November 24, 2023 13:22
@testower
Copy link
Contributor Author

There are still some outstanding tasks from the issue, I was hoping to get those done in separate pull requests.

Copy link
Member

@leonardehrenfried leonardehrenfried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said in today's meeting: I haven't read the code and don't feel that I need to. The integration with the rest of the system is minimal and good enough for a first version.

@daniel-heppner-ibigroup
Copy link
Contributor

I looked through the code and thought it was nicely written and fairly simple. I was able to see what was going on at a glance, which was nice.

Copy link
Contributor

@vesameskanen vesameskanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, modern and simple react app. Works without problems with our GTFS data.

@t2gran t2gran merged commit 93eb021 into opentripplanner:dev-2.x Dec 14, 2023
5 checks passed
@t2gran t2gran deleted the debug-client-next branch December 14, 2023 09:05
t2gran pushed a commit that referenced this pull request Dec 14, 2023
@t2gran
Copy link
Member

t2gran commented Dec 14, 2023

I merged this with just one approval, @leonardehrenfried had already approved it, and @daniel-heppner-ibigroup also gave it a +1 review. I hope that is ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement OTP Debug UI The OTP bundled client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants