Apply correct traversal permissions to barrier vertex

[vesameskanen]

Summary

Two bug fixes in barrier vertex:

• Bicicycle=no tag prevented car traversal, not bike traversal. Walk restriction had similar errors. Such errors are now fixed.
• Any kind of access restriction at the end vertex of a street (dead end alley, doorway etc.) caused failures in street routing, because route search could snap to an unreachable location. Routing could get infinitely close to the vertex but not to the final position. This problematic non-continuous behaviour is fixed by pruning the permissions of barrier vertices at the graph build stage where the street edge connections are known.

Issue

Closes #5353

Unit tests

Tests updated to reflect correct barrier permissions. One new unit test which tests barrier pruning added.

Documentation

Javadoc updated

[codecov]

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (f664f77) 66.50% compared to head (5e424de) 66.53%.
Report is 31 commits behind head on dev-2.x.

Additional details and impacted files

@@              Coverage Diff              @@
##             dev-2.x    #5369      +/-   ##
=============================================
+ Coverage      66.50%   66.53%   +0.02%     
- Complexity     15235    15255      +20     
=============================================
  Files           1785     1787       +2     
  Lines          69271    69303      +32     
  Branches        7291     7301      +10     
=============================================
+ Hits           46069    46110      +41     
+ Misses         20733    20719      -14     
- Partials        2469     2474       +5     

Files	Coverage Δ
...ripplanner/graph_builder/module/osm/OsmModule.java	93.86% <100.00%> (+0.09%)	⬆️
...g/opentripplanner/openstreetmap/model/OSMNode.java	95.23% <100.00%> (+1.90%)	⬆️
...entripplanner/openstreetmap/model/OSMWithTags.java	88.73% <100.00%> (ø)
...tripplanner/street/model/vertex/BarrierVertex.java	78.26% <68.75%> (-21.74%)	⬇️

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[leonardehrenfried]

One small thing, otherwise this looks good.

[optionsome]

I think static variables belong to the top of the class and should be named like MOTOR_VEHICLE_BARRIERS

[leonardehrenfried]

It's too late now because I don't want to hold up the merge of this PR but whenever we touch this code again, there is the following new helper method for checking if it's one of a set of tag values:

OpenTripPlanner/src/main/java/org/opentripplanner/openstreetmap/model/OSMWithTags.java

Lines 230 to 235 in f664f77

	/**
	* Takes a tag key and checks if the value is any of those in {@code oneOfTags}.
	*/
	public boolean isOneOfTags(String key, Set<String> oneOfTags) {
	return oneOfTags.stream().anyMatch(value -> isTag(key, value));
	}

[vesameskanen]

Oh yes, I forgot that new method. Let's fix this in some upcoming OSM related PR.