Import Occupancy Status from GTFS-RT Vehicle Positions

[optionsome]

Summary

• Expands internal model for OccupancyStatus to include all values from GTFS RT
• Imports OccupancyStatus from GTFS RT
• Exposes OccupancyStatus through trip in the GTFS API
• Renames vehicle position -> realtime vehicle in the internal model
  • Updater still uses the term vehicle position as it interacts with GTFS RT Vehicle Positions
• Adds supports for fuzzy trip matching in GTFS RT Vehicle Positions updater

Issue

closes #5364

Unit tests

Added

Documentation

Updated but might need slightly more

Changelog

From title

[codecov]

Codecov Report

Attention: 64 lines in your changes are missing coverage. Please review.

Comparison is base (b0d9a18) 66.60% compared to head (7793f69) 66.64%.
Report is 106 commits behind head on dev-2.x.

Additional details and impacted files

@@              Coverage Diff              @@
##             dev-2.x    #5372      +/-   ##
=============================================
+ Coverage      66.60%   66.64%   +0.04%     
- Complexity     15279    15397     +118     
=============================================
  Files           1790     1794       +4     
  Lines          69364    69682     +318     
  Branches        7306     7345      +39     
=============================================
+ Hits           46197    46437     +240     
- Misses         20690    20757      +67     
- Partials        2477     2488      +11     

Files	Coverage Δ
...tripplanner/ext/transmodelapi/model/EnumTypes.java	99.27% <100.00%> (+<0.01%)	⬆️
...rg/opentripplanner/apis/gtfs/GtfsGraphQLIndex.java	90.09% <100.00%> (+0.09%)	⬆️
...ripplanner/apis/gtfs/datafetchers/PatternImpl.java	18.75% <100.00%> (+1.78%)	⬆️
...r/apis/gtfs/datafetchers/StopRelationshipImpl.java	62.50% <ø> (+25.00%)	⬆️
...entripplanner/apis/gtfs/datafetchers/TripImpl.java	21.46% <100.00%> (+2.28%)	⬆️
...er/apis/gtfs/datafetchers/VehiclePositionImpl.java	100.00% <100.00%> (+9.09%)	⬆️
...anner/apis/gtfs/generated/GraphQLDataFetchers.java	0.00% <ø> (ø)
...ntripplanner/apis/gtfs/generated/GraphQLTypes.java	10.44% <100.00%> (+0.81%)	⬆️
...opentripplanner/apis/gtfs/model/TripOccupancy.java	100.00% <100.00%> (ø)
...hicles/internal/DefaultRealtimeVehicleService.java	100.00% <100.00%> (ø)
... and 21 more

... and 47 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[optionsome]

Was it that we use the config change label only when we create breaking changes? I will try to avoid doing that here (just need to figure out how to set default for the features).

[optionsome]

We went through the renaming commit issues with @t2gran today and came to the conclusion that it's not worth it to recreate commits to avoid missing history as the problem was only affecting a few small files.

[leonardehrenfried]

This branch has conflicts.

[leonardehrenfried]

@sam-hickey-ibigroup You will be interested to hear that realtime occupancy information is coming to OTP.

[t2gran]

Almost there ...

[t2gran]

Naming:

public interface RealtimeVehicleRepository {

[optionsome]

Hmm we already have a RealtimeVehicleRepository, this is a different class.

[t2gran]

Rename:

public interface RealtimeVehicleService {

[optionsome]

Same as above

[t2gran]

I would put this into ListUtils (or create CollectionsUtils):

@Nullable
public static <T> toString(Collection<T> c) {
  if(c == null) {
    return null;
  }
  return ((c instanceof List<T> list) ? list : List.copyOf(defaultValues)).toString();
}

Note! This is also handling null. If we should return "[]" and not null is a matter of taste. Both will work here.

[t2gran]

Tip: If you do not want to maintain all this doc in multiple places you could use the DocumentedEnum interface.

[leonardehrenfried]

I think we want to also generate the documentation for the default values of enum sets but that can come in a separate PR.