Fix check for OSM relation members not being present in the extract #5379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5379 +/- ##
=============================================
- Coverage 66.57% 66.56% -0.01%
Complexity 15273 15273
=============================================
Files 1790 1790
Lines 69367 69371 +4
Branches 7306 7307 +1
=============================================
- Hits 46181 46178 -3
- Misses 20710 20715 +5
- Partials 2476 2478 +2
☔ View full report in Codecov by Sentry. |
leonardehrenfried
changed the title
vesameskanen
previously approved these changes
Sep 28, 2023
leonardehrenfried
changed the title
vpaturet
requested changes
Oct 3, 2023
src/test/java/org/opentripplanner/graph_builder/module/osm/OsmDatabaseTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opentripplanner/graph_builder/module/osm/OsmDatabaseTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opentripplanner/graph_builder/module/osm/OsmDatabaseTest.java
Outdated
Show resolved
Hide resolved
vpaturet
approved these changes
Oct 6, 2023
vesameskanen
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes #5378.
The problem was that an OSM extract where relations refer to a way that isn't in that extract. We want to deal with it gracefully because compatibility with Geofabrik extracts is an important feature.
The thing is there was already a check if the way exists but it was looking at the wrong collection.
cc @atrawog
Issue
Fixes #5378
Unit tests
Added.