New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sort order bug in optimized transfers #5446
Merged
t2gran
merged 3 commits into
opentripplanner:dev-2.x
from
entur:otp2_fix_bug_in_optimized_transfers_5444
Oct 31, 2023
Merged
Fix sort order bug in optimized transfers #5446
t2gran
merged 3 commits into
opentripplanner:dev-2.x
from
entur:otp2_fix_bug_in_optimized_transfers_5444
Oct 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5446 +/- ##
=============================================
+ Coverage 66.76% 66.85% +0.08%
- Complexity 15445 15495 +50
=============================================
Files 1798 1800 +2
Lines 69777 69812 +35
Branches 7354 7353 -1
=============================================
+ Hits 46590 46674 +84
+ Misses 20725 20678 -47
+ Partials 2462 2460 -2
☔ View full report in Codecov by Sentry. |
...entripplanner/routing/algorithm/transferoptimization/services/OptimizePathDomainService.java
Outdated
Show resolved
Hide resolved
leonardehrenfried
previously approved these changes
Oct 23, 2023
jtorin
reviewed
Oct 24, 2023
...ipplanner/routing/algorithm/transferoptimization/services/OptimizePathDomainServiceTest.java
Outdated
Show resolved
Hide resolved
…timization/services/OptimizePathDomainServiceTest.java Co-authored-by: Johan Torin <jtorin@users.noreply.github.com>
Bartosz-Kruba
previously approved these changes
Oct 26, 2023
leonardehrenfried
approved these changes
Oct 30, 2023
Bartosz-Kruba
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The optimized path service relay on sorting transfer between two trips on the toTrip boardStopPosition. The sort function used board time, witch in most cases works. But, it is allowed to use the same time for two stops next to each other. Many trip schedules only uses minutes precision, so two stops close to each other can be visited within the same minute.
Issue
Closes #5444
Unit tests
A regression unit-test is added.
Documentation
Not applicable.
Changelog
✅ This is a minor bugfix.
Bumping the serialization version id
No