Check transport mode when mapping GroupStops#5518
Merged
vpaturet merged 2 commits intoNov 21, 2023
Merged
Conversation
vpaturet
added
!Improvement
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5518 +/- ##
=============================================
+ Coverage 66.93% 66.95% +0.01%
- Complexity 15700 15794 +94
=============================================
Files 1819 1832 +13
Lines 70248 70540 +292
Branches 7392 7410 +18
=============================================
+ Hits 47022 47229 +207
- Misses 20772 20840 +68
- Partials 2454 2471 +17 ☔ View full report in Codecov by Sentry. |
leonardehrenfried
requested changes
Nov 21, 2023
leonardehrenfried
left a comment
leonardehrenfried
left a comment
Member
There was a problem hiding this comment.
This looks good but please add some annotations for clarity and consider my suggestion.
leonardehrenfried
approved these changes
Nov 21, 2023
Bartosz-Kruba
approved these changes
Nov 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As detailed in #5506, when mapping "fixedStopAreaWide" FlexibleStopPlaces (i.e. "UnrestrictedPublicTransportAreas" stop areas), group stops should include only regular stops that match the transport mode of the FlexibleStopPlace.
Note: The Nordic NeTEx profile defines the transport mode as a mandatory field of a FlexibleStopPlace. If the transport mode is unset or unknown in the input dataset, no stop will be mapped.
Issue
Closes #5506
Unit tests
Updated unit tests.
Documentation
No.