New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check transport mode when mapping GroupStops #5518
Check transport mode when mapping GroupStops #5518
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5518 +/- ##
=============================================
+ Coverage 66.93% 66.95% +0.01%
- Complexity 15700 15794 +94
=============================================
Files 1819 1832 +13
Lines 70248 70540 +292
Branches 7392 7410 +18
=============================================
+ Hits 47022 47229 +207
- Misses 20772 20840 +68
- Partials 2454 2471 +17 ☔ View full report in Codecov by Sentry. |
src/main/java/org/opentripplanner/netex/mapping/FlexStopsMapper.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opentripplanner/netex/mapping/FlexStopsMapper.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good but please add some annotations for clarity and consider my suggestion.
Summary
As detailed in #5506, when mapping "fixedStopAreaWide" FlexibleStopPlaces (i.e. "UnrestrictedPublicTransportAreas" stop areas), group stops should include only regular stops that match the transport mode of the FlexibleStopPlace.
Note: The Nordic NeTEx profile defines the transport mode as a mandatory field of a FlexibleStopPlace. If the transport mode is unset or unknown in the input dataset, no stop will be mapped.
Issue
Closes #5506
Unit tests
Updated unit tests.
Documentation
No.