Report NO_TRANSIT_CONNECTION when search-window is set.

[t2gran]

Summary

The computation of NO_TRANSIT_CONNECTION is based on the the existence of the searchWindowUsed. This is not correct, and this PR make encapsulate this logic and uses the path and heuristic results in raptor instead.

Issue

🟥

Unit tests

🟥 The code here is not great and it is difficult to write a proper test. I do not have time to clean it up or write test for this, but I think it is better to fix the bug - then noting.

Documentation

✅ I have updated the doc in a few places.

Changelog

✅ This bug have probably existed in OTP for a long time.

Bumping the serialization version id

🟥 No needed.

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4230fd3) 67.35% compared to head (bc84e9a) 67.24%.
Report is 1 commits behind head on dev-2.x.

❗ Current head bc84e9a differs from pull request most recent head 51deb2b. Consider uploading reports for the commit 51deb2b to get more accurate results

Files	Patch %	Lines
...ripplanner/raptor/api/response/RaptorResponse.java	50.00%	0 Missing and 1 partial ⚠️
.../algorithm/raptoradapter/router/TransitRouter.java	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             dev-2.x    #5570      +/-   ##
=============================================
- Coverage      67.35%   67.24%   -0.12%     
+ Complexity     16162    16085      -77     
=============================================
  Files           1858     1852       -6     
  Lines          71093    70968     -125     
  Branches        7403     7399       -4     
=============================================
- Hits           47888    47723     -165     
- Misses         20745    20777      +32     
- Partials        2460     2468       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[leonardehrenfried]

Maybe I don't get it but doesn't this javadoc contradict the documentation of the error type?

[t2gran]

The doc on noTransitConnectionInSearchWindow is changed in this PR, but this is mapped to noTransitConnection.

noTransitConnection - "No transit connection was found between the origin and destination withing the operating day or the next day"

noTransitConnectionInSearchWindow- "Transit connection was found, but it was outside the search window, see metadata for the next search window"

[t2gran]

To be clear, we return noTransitConnection when you should not page and noTransitConnectionInSearchWindow when you should.

[leonardehrenfried]

I have a question about the docs: does it or doesn't it help to search with another page/search window?