Skip to content

Adding situation-version to TransmodelGraphQL API - #5592

Merged
lassetyr merged 2 commits into
opentripplanner:dev-2.xfrom
entur:entur_expose_situation_version
Jan 9, 2024
Merged

Adding situation-version to TransmodelGraphQL API#5592
lassetyr merged 2 commits into
opentripplanner:dev-2.xfrom
entur:entur_expose_situation_version

Conversation

@lassetyr

Copy link
Copy Markdown
Contributor

Summary

Exposes the version-field from a SIRI SX-message in the TransmodelGraphQL-api - if it exists.

@lassetyr lassetyr added the +Real-Time The issue/PR is related to RealTime updates label Dec 21, 2023
@lassetyr
lassetyr requested a review from a team as a code owner December 21, 2023 12:35
@codecov

codecov Bot commented Dec 21, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (8520a1a) 67.45% compared to head (97cf60c) 67.46%.
Report is 50 commits behind head on dev-2.x.

Files Patch % Lines
...ntripplanner/ext/siri/SiriAlertsUpdateHandler.java 0.00% 1 Missing and 1 partial ⚠️
...entripplanner/routing/alertpatch/TransitAlert.java 33.33% 2 Missing ⚠️
...lanner/routing/alertpatch/TransitAlertBuilder.java 33.33% 2 Missing ⚠️
...ripplanner/raptor/api/response/RaptorResponse.java 50.00% 0 Missing and 1 partial ⚠️
.../algorithm/raptoradapter/router/TransitRouter.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #5592   +/-   ##
==========================================
  Coverage      67.45%   67.46%           
+ Complexity     16195    16189    -6     
==========================================
  Files           1858     1862    +4     
  Lines          71130    71199   +69     
  Branches        7409     7403    -6     
==========================================
+ Hits           47984    48031   +47     
- Misses         20669    20677    +8     
- Partials        2477     2491   +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leonardehrenfried
leonardehrenfried self-requested a review December 21, 2023 15:11
@leonardehrenfried leonardehrenfried changed the title Adding situation-version to TransmodelGraphQL-api Adding situation-version to TransmodelGraphQL API Dec 21, 2023

@leonardehrenfried leonardehrenfried left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please document the nullablity.

@lassetyr
lassetyr merged commit 823f2e8 into opentripplanner:dev-2.x Jan 9, 2024
@lassetyr
lassetyr deleted the entur_expose_situation_version branch January 9, 2024 15:02
t2gran pushed a commit that referenced this pull request Jan 9, 2024
@t2gran t2gran added this to the 2.5 (next release) milestone Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

+Real-Time The issue/PR is related to RealTime updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants