Adding situation-version to TransmodelGraphQL API - #5592
Merged
lassetyr merged 2 commits intoJan 9, 2024
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5592 +/- ##
==========================================
Coverage 67.45% 67.46%
+ Complexity 16195 16189 -6
==========================================
Files 1858 1862 +4
Lines 71130 71199 +69
Branches 7409 7403 -6
==========================================
+ Hits 47984 48031 +47
- Misses 20669 20677 +8
- Partials 2477 2491 +14 ☔ View full report in Codecov by Sentry. |
leonardehrenfried
self-requested a review
December 21, 2023 15:11
t2gran
reviewed
Jan 2, 2024
leonardehrenfried
requested changes
Jan 5, 2024
leonardehrenfried
left a comment
Member
There was a problem hiding this comment.
Please document the nullablity.
leonardehrenfried
approved these changes
Jan 5, 2024
jtorin
approved these changes
Jan 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exposes the version-field from a SIRI SX-message in the TransmodelGraphQL-api - if it exists.