Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Transmodel API path to /otp/transmodel/v3 #5637

Merged

Conversation

leonardehrenfried
Copy link
Member

@leonardehrenfried leonardehrenfried commented Jan 23, 2024

Summary

This PR changes the path of the Transmodel API to /otp/transmodel/v3. In line with others it is totally backwards-compatible and you can keep using the old path for the time being.

In line with @t2gran's suggestion the endpoint at /otp/routers/default/transmodel/live has been removed as it simplified the migration of this path a lot.

Issue

#4052

Documentation

Updated.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (4e4af20) 67.50% compared to head (6d07809) 67.46%.
Report is 6 commits behind head on dev-2.x.

Files Patch % Lines
...xt/reportapi/model/TransitGroupPriorityReport.java 0.00% 39 Missing ⚠️
...planner/ext/reportapi/resource/ReportResource.java 0.00% 4 Missing ⚠️
...opentripplanner/apis/transmodel/TransmodelAPI.java 0.00% 3 Missing ⚠️
...in/java/org/opentripplanner/apis/APIEndpoints.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #5637      +/-   ##
=============================================
- Coverage      67.50%   67.46%   -0.05%     
+ Complexity     16285    16284       -1     
=============================================
  Files           1888     1889       +1     
  Lines          71547    71591      +44     
  Branches        7408     7412       +4     
=============================================
- Hits           48301    48300       -1     
- Misses         20747    20791      +44     
- Partials        2499     2500       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

leonardehrenfried and others added 2 commits January 24, 2024 10:21
Co-authored-by: Thomas Gran <t2gran@gmail.com>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t2gran t2gran added this to the 2.5 (next release) milestone Jan 26, 2024
@leonardehrenfried leonardehrenfried merged commit 5485479 into opentripplanner:dev-2.x Jan 26, 2024
5 checks passed
@leonardehrenfried leonardehrenfried deleted the transmodel-path branch January 26, 2024 19:16
t2gran pushed a commit that referenced this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants