New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Transmodel API path to /otp/transmodel/v3
#5637
Merged
leonardehrenfried
merged 4 commits into
opentripplanner:dev-2.x
from
leonardehrenfried:transmodel-path
Jan 26, 2024
Merged
Change Transmodel API path to /otp/transmodel/v3
#5637
leonardehrenfried
merged 4 commits into
opentripplanner:dev-2.x
from
leonardehrenfried:transmodel-path
Jan 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5637 +/- ##
=============================================
- Coverage 67.50% 67.46% -0.05%
+ Complexity 16285 16284 -1
=============================================
Files 1888 1889 +1
Lines 71547 71591 +44
Branches 7408 7412 +4
=============================================
- Hits 48301 48300 -1
- Misses 20747 20791 +44
- Partials 2499 2500 +1 ☔ View full report in Codecov by Sentry. |
t2gran
reviewed
Jan 23, 2024
Co-authored-by: Thomas Gran <t2gran@gmail.com>
leonardehrenfried
requested review from
t2gran and
habrahamsson-skanetrafiken
January 24, 2024 09:23
habrahamsson-skanetrafiken
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
t2gran
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the path of the Transmodel API to
/otp/transmodel/v3
. In line with others it is totally backwards-compatible and you can keep using the old path for the time being.In line with @t2gran's suggestion the endpoint at
/otp/routers/default/transmodel/live
has been removed as it simplified the migration of this path a lot.Issue
#4052
Documentation
Updated.