Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate walk time from non-transit time #5648

Merged
merged 8 commits into from Feb 1, 2024

Conversation

leonardehrenfried
Copy link
Member

Summary

@amy-corson-ibigroup has reported that the GTFS API falsely returns the non-transit duration as the walk one.

This is fixed by this PR.

This is just a minimal PR to fix the actual issue, but I want to create a follow-up where I rework this system and make a more general API for show all sorts of durations for walking, biking and driving.

Unit tests

✔️

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (14aca8a) 67.54% compared to head (7fc2e87) 67.54%.
Report is 1 commits behind head on dev-2.x.

Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #5648   +/-   ##
==========================================
  Coverage      67.54%   67.54%           
- Complexity     16293    16297    +4     
==========================================
  Files           1888     1888           
  Lines          71609    71617    +8     
  Branches        7405     7406    +1     
==========================================
+ Hits           48365    48373    +8     
+ Misses         20741    20740    -1     
- Partials        2503     2504    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leonardehrenfried leonardehrenfried changed the title Walk time Separate walk time from non-transit time Jan 29, 2024
@t2gran t2gran added this to the 2.5 (next release) milestone Jan 30, 2024
@t2gran t2gran requested review from vesameskanen and jtorin and removed request for vesameskanen January 30, 2024 09:42
vesameskanen
vesameskanen previously approved these changes Jan 31, 2024
@leonardehrenfried leonardehrenfried merged commit a50ef42 into opentripplanner:dev-2.x Feb 1, 2024
5 checks passed
t2gran pushed a commit that referenced this pull request Feb 1, 2024
@leonardehrenfried leonardehrenfried deleted the walk-time branch February 1, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants