Separate walk time from non-transit time#5648
Merged
Merged
Conversation
leonardehrenfried
added
the
!Bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5648 +/- ##
==========================================
Coverage 67.54% 67.54%
- Complexity 16293 16297 +4
==========================================
Files 1888 1888
Lines 71609 71617 +8
Branches 7405 7406 +1
==========================================
+ Hits 48365 48373 +8
+ Misses 20741 20740 -1
- Partials 2503 2504 +1 ☔ View full report in Codecov by Sentry. |
leonardehrenfried
force-pushed
the
walk-time
branch
from
617f817 to
c7631ff
Compare
t2gran
requested review from
jtorin and
vesameskanen
and removed request for
vesameskanen
vesameskanen
previously approved these changes
Jan 31, 2024
jtorin
approved these changes
Feb 1, 2024
vesameskanen
approved these changes
Feb 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@amy-corson-ibigroup has reported that the GTFS API falsely returns the non-transit duration as the walk one.
This is fixed by this PR.
This is just a minimal PR to fix the actual issue, but I want to create a follow-up where I rework this system and make a more general API for show all sorts of durations for walking, biking and driving.
Unit tests
✔️