Reduce flex default access/egress penalty#5674
Merged
leonardehrenfried merged 2 commits intoFeb 14, 2024
Merged
Conversation
leonardehrenfried
added
the
!Improvement
leonardehrenfried
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5674 +/- ##
==========================================
Coverage 67.62% 67.62%
- Complexity 16293 16294 +1
==========================================
Files 1886 1886
Lines 71549 71551 +2
Branches 7384 7384
==========================================
+ Hits 48383 48385 +2
Misses 20661 20661
Partials 2505 2505 ☔ View full report in Codecov by Sentry. |
Member
Author
|
@vpaturet Here is a config example: ibi-group@c2afe26 |
t2gran
approved these changes
Feb 13, 2024
t2gran
left a comment
t2gran
left a comment
Member
There was a problem hiding this comment.
This looks ok. There is a bug #5681 witch is related to the penalty. Since this is lowering the penalty the bug appear less frequently. Hence; I am in favour of just merging this, not waiting for a bug fix.
For those who run into this bug, we suggest configuring the penalty, setting it to zero - OR reverting to an older version OTP until the bug is fixed.
vpaturet
approved these changes
Feb 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In a previous PR #5381 I set the flex accessEgress penalty to the same value as Park&Ride. It turns out that this is too aggressive and I lowered the value accordingly.
Documentation
Autogenerated.