Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hamburg OSM mapper #5701

Merged

Conversation

2martens
Copy link
Contributor

Summary

Adds a custom OSM mapper for Hamburg to improve routing.

Issue

Closes #5700

Documentation

The build configuration was updated with new enum value.

Unit tests

  • unit tests were added to test updated behaviour

@2martens 2martens requested a review from a team as a code owner February 22, 2024 16:04
@2martens
Copy link
Contributor Author

2martens commented Feb 22, 2024

The divergence of the SiriAzureUpdater.md is caused by a breaking state of the dev-2.x branch where the file wasn't properly updated.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 67.70%. Comparing base (7be0113) to head (b38259f).
Report is 10 commits behind head on dev-2.x.

Files Patch % Lines
...lanner/openstreetmap/tagmapping/HamburgMapper.java 75.00% 0 Missing and 1 partial ⚠️
...r/openstreetmap/tagmapping/OsmTagMapperSource.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #5701      +/-   ##
=============================================
- Coverage      67.70%   67.70%   -0.01%     
- Complexity     16375    16377       +2     
=============================================
  Files           1891     1892       +1     
  Lines          71873    71887      +14     
  Branches        7409     7412       +3     
=============================================
+ Hits           48665    48674       +9     
- Misses         20701    20703       +2     
- Partials        2507     2510       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vpaturet
vpaturet previously approved these changes Feb 28, 2024
@leonardehrenfried leonardehrenfried merged commit abd7ecd into opentripplanner:dev-2.x Feb 28, 2024
5 checks passed
t2gran pushed a commit that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Hamburg-specific OSM mapper
4 participants