Skip to content

Add Hamburg OSM mapper - #5701

Merged
leonardehrenfried merged 10 commits into
opentripplanner:dev-2.xfrom
HBTGmbH:feature/hamburg-osm-mapper
Feb 28, 2024
Merged

Add Hamburg OSM mapper#5701
leonardehrenfried merged 10 commits into
opentripplanner:dev-2.xfrom
HBTGmbH:feature/hamburg-osm-mapper

Conversation

@2martens

Copy link
Copy Markdown
Contributor

Summary

Adds a custom OSM mapper for Hamburg to improve routing.

Issue

Closes #5700

Documentation

The build configuration was updated with new enum value.

Unit tests

  • unit tests were added to test updated behaviour

@2martens
2martens requested a review from a team as a code owner February 22, 2024 16:04
@2martens
2martens force-pushed the feature/hamburg-osm-mapper branch from c9f939d to d68ceda Compare February 22, 2024 16:09
@2martens

2martens commented Feb 22, 2024

Copy link
Copy Markdown
Contributor Author

The divergence of the SiriAzureUpdater.md is caused by a breaking state of the dev-2.x branch where the file wasn't properly updated.

@2martens
2martens force-pushed the feature/hamburg-osm-mapper branch from d68ceda to 6df6a00 Compare February 23, 2024 13:05
@codecov

codecov Bot commented Feb 23, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 67.70%. Comparing base (7be0113) to head (b38259f).
Report is 10 commits behind head on dev-2.x.

Files Patch % Lines
...lanner/openstreetmap/tagmapping/HamburgMapper.java 75.00% 0 Missing and 1 partial ⚠️
...r/openstreetmap/tagmapping/OsmTagMapperSource.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #5701      +/-   ##
=============================================
- Coverage      67.70%   67.70%   -0.01%     
- Complexity     16375    16377       +2     
=============================================
  Files           1891     1892       +1     
  Lines          71873    71887      +14     
  Branches        7409     7412       +3     
=============================================
+ Hits           48665    48674       +9     
- Misses         20701    20703       +2     
- Partials        2507     2510       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread src/main/java/org/opentripplanner/openstreetmap/tagmapping/HamburgMapper.java Outdated
@leonardehrenfried leonardehrenfried added the !New Feature A functional feature targeting the end user. label Feb 26, 2024
vpaturet
vpaturet previously approved these changes Feb 28, 2024
@2martens
2martens dismissed stale reviews from vpaturet and leonardehrenfried via 78d9169 February 28, 2024 14:49
@leonardehrenfried
leonardehrenfried merged commit abd7ecd into opentripplanner:dev-2.x Feb 28, 2024
t2gran pushed a commit that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

!New Feature A functional feature targeting the end user.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Hamburg-specific OSM mapper

4 participants