Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAIS/CrossEntropy: add samples accessors for each step with selection #2468

Closed
jschueller opened this issue Nov 13, 2023 · 5 comments · Fixed by #2530
Closed

NAIS/CrossEntropy: add samples accessors for each step with selection #2468

jschueller opened this issue Nov 13, 2023 · 5 comments · Fixed by #2530
Assignees

Comments

@jschueller
Copy link
Member

What is the idea?

Accessors could be added, see SubsetSampling methods getIn|OutputSample(k, select) for step k and select flag

Why is this needed?

No response

Additional Context

No response

@m-balesdent
Copy link
Collaborator

Currently, these samples can be accessed with an old fashion way : see this example

I agree a dedicated accessor could be better !

Do you mean accessors for both input and output samples ?

@jschueller
Copy link
Member Author

input/output, per step and per failed/ok

@m-balesdent
Copy link
Collaborator

Hi @jschueller ,

I am going to change NAIS / Cross Entropy algorithms to add samples accessors.

In subsetsampling, the samples for each step are currently saved inside the subsetsampling class (and accessors are present in the subsetsampling) but I'm wondering if it could be more convenient for the user to set the acessors in the subsetsampling results class instead of subsetsampling. What is your opinion on that topic?

Thanks

@jschueller
Copy link
Member Author

this is the right thing to do unfortunately it cannot be exposed as the result is currenlty only exposed via the parent class,
so adding methods wont be easy, thats probably why I added it to the algo class

@m-balesdent
Copy link
Collaborator

OKay, I will do the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants