add progress bar for unit evalution #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jschueller |
adumasphi
force-pushed
the
progress_bar
branch
2 times, most recently
from
f6de8f6
to
1b51259
Compare
jschueller
reviewed
Jan 16, 2024
adumasphi
force-pushed
the
progress_bar
branch
from
1b51259
to
641cbac
Compare
jschueller
reviewed
Jan 17, 2024
| @@ -574,7 +609,7 @@ def __init__(self, wrapper, backend='multiprocessing', n_cpus=-1, verbosity=10, | |||
|
|
|||
| # This configures how to run samples on the model : | |||
| if self.n_cpus == 1: | |||
| self._exec_sample = self.wrapper | |||
| self._exec_sample = _exec_sample_unit_progress_bar(self.wrapper, verbosity) | |||
|
|
|||
There was a problem hiding this comment.
lets actually allow a "progress_bar" backend keyword, so the condition rewrites if backend=="progress_bar" or self.n_cpus == 1
it should be renamed "serial" though which is more explicit (rename the function _exec_sample_serial too)
jschueller
reviewed
Jan 17, 2024
tests/test_wrapper.py
Outdated
| @@ -8,6 +8,9 @@ def backendtest(backend): | |||
| ot.RandomGenerator.SetSeed(0) | |||
| n_cpu = multiprocessing.cpu_count() | |||
| sizes = [1, n_cpu, n_cpu + 1] | |||
| if backend == 'progress_bar': | |||
| backend = 'multiprocessing' # default backend not really used | |||
| n_cpu = 1 | |||
There was a problem hiding this comment.
then here we could actually drop this and allow for the "serial" backend
jschueller
reviewed
Jan 17, 2024
adumasphi
force-pushed
the
progress_bar
branch
from
641cbac
to
b6e3f56
Compare
adumasphi
force-pushed
the
progress_bar
branch
from
b6e3f56
to
f3b6a56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.