Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Input" with multiple source doesn't work except if source comes from the same stick. #1730

Closed
Sacre100 opened this issue Sep 19, 2014 · 21 comments

Comments

@Sacre100
Copy link

OpenTx 2.0.12 same behavior into TX and into Simulator.

If you create an "input" with two or more line with for exemple, first source LS and second source RS, the "input" react only from LS.

Only when the sources are from the SAME stick, for exemple, first source horizontal left stick and second source vertical left stick, the "input" react on both source.

@kilrah
Copy link
Member

kilrah commented Sep 19, 2014

Seems to work fine here.
Only ONE line of an input can be active at the same time, it is not a mixer. Could help if you said exactly what you entered and expected, please reopen with more details if confirmed.

@kilrah kilrah closed this as completed Sep 19, 2014
@Sacre100
Copy link
Author

This is confusing, "input" act as mixer if source comes from same stick !
I expected that "input" act as mixer.

"Input" acting as mixer allows to reduce the usage of channel (and loose it for servo) for complex mix.

@ghost
Copy link

ghost commented Sep 19, 2014

The stick moves two pots. Each of them is an input. You cannot mix them in inputs, but you can mix them in mixes for one channel to drive one servo output. You have 32 channels to use for mixes. Are you using them all.
In inputs you can use a switch to change from one input to another, but not mix them.
I guess English is not your first language, so perhaps we are misunderstanding what you are asking.
Tom

@Sacre100
Copy link
Author

Correct, English is not my first language.

"Input" can mix the two pots of one stick ("haft" is perhaps the correct word), but not pots from different stick.

Currently, if someone (it's not my case yet) has to use 32 servos and make complex mixes, he will be in trouble. If OpenTx allows to make mixes in "input", he will be able to use 32 servos and complex mixes.

@kilrah
Copy link
Member

kilrah commented Sep 19, 2014

Yes probably a misunderstanding. Inputs can not mix anything, so I don't really know what you mean.

@LapinFou
Copy link
Contributor

Maybe I may help here. The request of Sacre 100 is:
In the "Input tab", it is possible to assign different sources for the same input ? Currently if we do that, only the first source will toggle the input.
For example I would like that my Input number 5 reacts for any information coming from the source Rudder, Elevator AND Aileron. Off course this can be done in the "Mixes" tab, but then you will lose one servo output.

@ghost
Copy link

ghost commented Sep 19, 2014

You can mix every channel in mixes , channel by channel and still have all 32 channels driving servo outputs. Inputs are for pre-conditioning the input from sticks, switches and everything else that can be used as an input. They can also be used to select different, such as rates and expo etc., conditions by using a switch to select the line.

@ghost
Copy link

ghost commented Sep 19, 2014

LapinFou, why would you lose a servo output?

@Sacre100
Copy link
Author

Ok, understood, but this is the first time I'm disappointed with OpenTx.

@LapinFou
Copy link
Contributor

OK. I will go in more details. The discussion started with Sacre100 about a special training mode. Basically, the idea is to use a "Sticky" function to activate the trainer mode with a short press on SH, then the trainer mode will deactivated if any movement is detected on the gimbal of the master TX. To achieve this behavior we need to mix Rudder, Elevator AND Aileron (without trims off course).
This can be done in mixes, but we though it was also possible to achieve the same behavior in "Inputs" tabs.

@LapinFou
Copy link
Contributor

@tomkfly
Well if you are using 1 mix as a kind of "virtual mix" for some special function, then this mix cannot be assigned to a real servo. From my understanding: one mix = one servo. Or did I get it wrong? Is it possible to assign the same mix for several servo output?

@bsongis
Copy link
Member

bsongis commented Sep 19, 2014

Yes it will be possible to do that, but not in 2.0 release. I plan to add this support as an option in 2.1 We will have those options in 2.1 for the inputs system:

  • super simple inputs = ersky9x / er9x system, fixed order, only dual rates and expos
  • "normal" inputs = opentx today
  • "complex" inputs = a new mixer stage, exactly what you need right now

An issue is already opened for this enhancement request
#1659

@bsongis
Copy link
Member

bsongis commented Sep 19, 2014

I am currently working on the whole telemetry refactoring. This will be done later. It would be good if somebody had time to help me a little bit on this one, it's not complex at all, the code already exists, just needs to be sorted.

@LapinFou
Copy link
Contributor

I'm impressed of fast you react! :)
I read the enhancement request. Indeed, it looks like what we are looking for. If it is possible to do some complex mixing, then apply the result of this complex mixing to one classic mix (where on mix = 1 servo output), then we are done!
I would have been happy to help, unfortunately I'm not a software guy. Sorry :(

@ghost
Copy link

ghost commented Sep 19, 2014

Usually a virtual channel is a convenience, but not always the only way. However, you may have a situation where a virtual channel may be the only reasonable way. However, That is not a problem with a simple Trainer mix. I think it a bit much to say he is disappointed, when the developers are doing this in their own free time to produce a system like this free, with a few pennies donated, by a few users, that don't even cover the costs.

Tom

@LapinFou
Copy link
Contributor

Being an open source developer is often thankless. That is an unfair game. Anyway you are doing a great job and many many people are very happy! Currently I'm playing with 'companion', however I soon as I received my Taranis, I promise I will donate to the team.

@kilrah
Copy link
Member

kilrah commented Sep 19, 2014

Off course this can be done in the "Mixes" tab, but then you will lose one servo output.

I don't think anybody on this planet actually needs all 32 outputs. I can't really understand the "OMG I can't use that, I only use 8 outputs but maybe one day I might need all 32!!"
The desired function can be done using a virtual channel, that's what they're for, and there's nothing wrong with doing it that way...

@Sacre100
Copy link
Author

@bsongis Thank you for your response, my mindset goes from disappointed to impatient.
@kilrah Imagine a firefighter boat with fire hoses, or a military ship with cannons and turrets.

@ghost
Copy link

ghost commented Sep 19, 2014

Here is a link to trainer setups I posted on RCGroups
http://www.rcgroups.com/forums/showpost.php?p=29069336&postcount=3421
The text may be out of date as I updated the EEPE and have not got around to updating the text.
One thing, don't use the trainer function in Special Functions, or it won't work as it reads the controls as if they were on the master. You need to assign the controls a tAil, tThr, tEle, tRud..switched by the Logic switch. And use replace in the mix

Tom

@kilrah
Copy link
Member

kilrah commented Sep 19, 2014

Imagine a firefighter boat with fire hoses, or a military ship with cannons and turrets.

We've already got several users doing that, yet none has been short of channels yet :)
I mean it's not like if it was something important.

@LapinFou
Copy link
Contributor

@tomkfly
I was not the only one to dream about this function! :)
I had a look in you EEPE file, I've got one comment: What about the trim? In you first trainer mode, if a trim is added on the ailerons, then this will have an impact on threshold detection. I think you should had the option "no trim" on CH15.
To be clear of what I mean, you may have a look on the tutorial I've done on a French Taranis forum:
http://frskytaranis.forumactif.org/t1218-tuto-ecolage-sans-maintenir-le-bouton-appuye
@kilrah
From all Taranis users I know, the ones who got an external RF module is to keep a compatibility with Spektrum (or other) RXs, not for 32 channels purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants