Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENTER/MOUSE-MID defined in the simulator help is not correct #4585

Closed
LapinFou opened this issue Mar 10, 2017 · 7 comments

Comments

Projects
None yet
3 participants
@LapinFou
Copy link
Contributor

commented Mar 10, 2017

When doing the French translation (and testing the RC11 at the same time), I discovered that the help in the simualtor is wrong.
ENTER/MOUSE-MID should be ENTER/MOUSE-LEFT

@LapinFou LapinFou added the Companion label Mar 10, 2017

@LapinFou LapinFou added this to the OpenTX 2.2.1 milestone Mar 10, 2017

@LapinFou LapinFou changed the title ENTER/MOUSE-MID defined in the the simulator help is not correct ENTER/MOUSE-MID defined in the simulator help is not correct Mar 10, 2017

@mpaperno

This comment has been minimized.

Copy link
Member

commented Mar 11, 2017

Mouse left button? That doesn't change normal meaning. Mouse MID will (or should) activate the radio "action" (ENT/MENU/Rotary click) while anywhere over the Simulator window. So I'm not sure what you mean.

That said, I did find some issues in the help text and the controls themselves, which I have changed already in my working copy. I'm also centralizing all the strings in one file to make it simpler to maintain/translate. So don't spend much time translating the keyboard help text right now.

E.g. from X9E:
image

What do you think of the icons?

@kilrah

This comment has been minimized.

Copy link
Member

commented Mar 11, 2017

ENTER/MOUSE-MID should be ENTER/MOUSE-LEFT

Umm no, it's correct... :\

What do you think of the icons?

Yep why not!

@LapinFou

This comment has been minimized.

Copy link
Contributor Author

commented Mar 11, 2017

Well I guess I didn't understand what this ENTER/MOUSE-MID is for.
With the X9D+ simulator, the middle click doesn't work on the 6 buttons (PAGE, MENU, etc...). But, the left click does.
However with the LUA script (for example the Wizard), I can scroll with the mouse to select, then use the middle button to confirm the action.

@kilrah

This comment has been minimized.

Copy link
Member

commented Mar 11, 2017

Left-click on the buttons activates them, including the rotary encoder "enter" push.
Mid mouse activates the rotary encoder push regardless of where the cursor is.

@mpaperno

This comment has been minimized.

Copy link
Member

commented Mar 12, 2017

Ah, I see... ironically, mid-clicking anywhere BUT in the button areas works correctly. But while cursor is over the control areas on the left/right, mid-click doesn't actually work at all. I think I also know why... yes, much better now (fixed... porting... testing... committing...).

@mpaperno mpaperno closed this in f103c88 Mar 12, 2017

@mpaperno

This comment has been minimized.

Copy link
Member

commented Mar 12, 2017

Now if mid-clicking on a radio key, that key is activated. Otherwise default mid-click action is triggered (enter/rotary click/etc). I tried it so the default action is always triggered, but it was awkward and counter-intuitive when mid-clicking on a different key and instead "enter" was being pressed.

@LapinFou

This comment has been minimized.

Copy link
Contributor Author

commented Mar 12, 2017

Thanks!
😄

@kilrah kilrah modified the milestones: OpenTX 2.2.1, OpenTX 2.2.0 May 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.