CL/HIER: alltoall single proc on node fix #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimmybalsam
force-pushed
the
alltoall_atest_fix
branch
2 times, most recently
from
f787aa2
to
0f8e4dd
Compare
shimmybalsam
requested review from
Sergei-Lebedev,
bureddy,
samnordmann and
manjugv
bureddy
reviewed
Oct 25, 2022
bureddy
approved these changes
Oct 25, 2022
samnordmann
approved these changes
Oct 25, 2022
samnordmann
reviewed
Oct 25, 2022
shimmybalsam
force-pushed
the
alltoall_atest_fix
branch
2 times, most recently
from
d1f35b5
to
b3508fc
Compare
shimmybalsam
force-pushed
the
alltoall_atest_fix
branch
from
b3508fc
to
0711680
Compare
Sergei-Lebedev
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Bug fix #3213667.
Why ?
CL/HIER alltoall and alltoallv was hanging due to single process on node case being disabled.
How ?
Enabling single process on node, in which case only "full_task" (aka intra node) sends original args data without overwriting counts and displacements. In this case "node_task" (inter node) will not be initiated nor added to schedule.