TL/UCP: bcast opt #738
Merged
TL/UCP: bcast opt #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergei-Lebedev
requested review from
shimmybalsam,
bureddy,
manjugv and
vspetrov
Sergei-Lebedev
force-pushed
the
topic/bcast_sag_opt
branch
from
f730476
to
06a8c8e
Compare
shimmybalsam
suggested changes
Mar 6, 2023
| @@ -146,6 +145,7 @@ void ucc_tl_ucp_scatter_knomial_progress(ucc_coll_task_t *coll_task) | |||
| peer_seg_count * dt_size, mem_type, INV_VRANK(peer, | |||
| (ucc_rank_t)args->root, size), team, task), task, out); | |||
| } | |||
| /*TODO: local_seg_index is always zero since rank that sends is base root? */ | |||
There was a problem hiding this comment.
is this TODO still a needed cooment?
There was a problem hiding this comment.
yes, i think this statement is true and we can clean code a bit
| @@ -165,8 +165,8 @@ void ucc_tl_ucp_scatter_knomial_progress(ucc_coll_task_t *coll_task) | |||
| &offset, &local_seg_count); | |||
| if (offset != 0) { | |||
| status = ucc_mc_memcpy(PTR_OFFSET(args->dst.info.buffer, offset), | |||
| PTR_OFFSET(rbuf, task->scatter_kn.send_offset), | |||
| local_seg_count * dt_size, mem_type, mem_type); | |||
| rbuf, task->scatter_kn.recv_size, mem_type, | |||
There was a problem hiding this comment.
why copying from rbuf without send_offset?
There was a problem hiding this comment.
we want to copy everything that we receive so far to have less number of communications in allgather step after it
manjugv
approved these changes
Mar 14, 2023
Sergei-Lebedev
force-pushed
the
topic/bcast_sag_opt
branch
from
06a8c8e
to
129943b
Compare
shimmybalsam
approved these changes
Mar 15, 2023
bureddy
approved these changes
Mar 15, 2023
jeniaka
pushed a commit
to jeniaka/ucc
that referenced
this pull request
Jun 22, 2023
* TL/UCP: bcast sag opt * REVIEW: fix review comments
janjust
pushed a commit
to janjust/ucc
that referenced
this pull request
Jan 31, 2024
* TL/UCP: bcast sag opt * REVIEW: fix review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Pull request contains multiple optimizations for TL/UCP broadcast
How ?
2.Wait for recv completion only to continue to the next iteration