-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate configure
scripts
#8642
Comments
@jakirkham to be clear, are you suggesting that the default ./configure will behave the same as ./contrib/configure-release? |
Yeah that's right. Would that be possible? Or are there other things to consider before approaching such a change? |
@jakirkham It is quite challenging to come up with such config. For example, the most optimal build config enables u-arch optimizations that are not portable across machines. The multi-threaded build enables flows that will not be as optimal for apps that don't care about multithreading, etc. Essentially, the options and configurations that are optimal for one user may not be optimal for another user. |
IMO we can make the default configure closer to configure-release, but it still has to be multi-threaded and without non portable uarch optimizations |
@jakirkham Maybe you can share some details, why you believe this is an issue today. thanks |
Currently there is a top-level
configure
script generated byautoconf
. Typically this is what most builders would use by default, but UCX has aconfigure-release
that is incontrib
, which is recommended by the docs. Though there is also a multithreaded release script as well. Plus there are few moreconfigure
scripts in thecontrib
directory.Would it be possible to consolidate this into a single
configure
that sets most things up for a performant release build? Perhaps there are still someconfigure
scripts for development that need to hang around incontrib
, but this would make it easier for others building and shipping UCX to users to get started.cc @pentschev @leofang
The text was updated successfully, but these errors were encountered: