Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate configure scripts #8642

Open
jakirkham opened this issue Oct 18, 2022 · 5 comments
Open

Consolidate configure scripts #8642

jakirkham opened this issue Oct 18, 2022 · 5 comments

Comments

@jakirkham
Copy link
Contributor

jakirkham commented Oct 18, 2022

Currently there is a top-level configure script generated by autoconf. Typically this is what most builders would use by default, but UCX has a configure-release that is in contrib, which is recommended by the docs. Though there is also a multithreaded release script as well. Plus there are few more configure scripts in the contrib directory.

Would it be possible to consolidate this into a single configure that sets most things up for a performant release build? Perhaps there are still some configure scripts for development that need to hang around in contrib, but this would make it easier for others building and shipping UCX to users to get started.

cc @pentschev @leofang

@yosefe
Copy link
Contributor

yosefe commented Oct 18, 2022

@jakirkham to be clear, are you suggesting that the default ./configure will behave the same as ./contrib/configure-release?

@jakirkham
Copy link
Contributor Author

Yeah that's right. Would that be possible? Or are there other things to consider before approaching such a change?

@shamisp
Copy link
Contributor

shamisp commented Oct 18, 2022

@jakirkham It is quite challenging to come up with such config. For example, the most optimal build config enables u-arch optimizations that are not portable across machines. The multi-threaded build enables flows that will not be as optimal for apps that don't care about multithreading, etc. Essentially, the options and configurations that are optimal for one user may not be optimal for another user.

@yosefe
Copy link
Contributor

yosefe commented Oct 18, 2022

IMO we can make the default configure closer to configure-release, but it still has to be multi-threaded and without non portable uarch optimizations

@shamisp
Copy link
Contributor

shamisp commented Oct 18, 2022

@jakirkham Maybe you can share some details, why you believe this is an issue today. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants