UCP/PROTO: Simplify RNDV_SCHEME env logic #9815
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakhmets
reviewed
Apr 11, 2024
iyastreb
reviewed
Apr 12, 2024
test/gtest/ucp/test_ucp_tag_xfer.cc
Outdated
| UCS_TEST_P(test_ucp_tag_xfer, send_contig_recv_generic_unexp_sync_rndv, | ||
| "RNDV_THRESH=1000", "ZCOPY_THRESH=1248576") { | ||
| UCP_TEST_TAG_RNDV_GENERIC(test_ucp_tag_xfer, send_contig_recv_generic_unexp_sync_rndv, | ||
| "ZCOPY_THRESH=1248576") { |
test/gtest/ucp/ucp_test.h
Outdated
| @@ -333,6 +333,9 @@ class ucp_test : public ucp_test_base, | |||
| // Return context parameters of the current test variant | |||
| const ucp_params_t& get_variant_ctx_params() const; | |||
|
|
|||
| // Check whether sender and receiver supports certain caps | |||
| bool supports_caps(uint64_t rndv_modes) const; | |||
There was a problem hiding this comment.
minor: maybe name it support_caps or is_support_caps?
It's unusual to have s suffix for verbs in function names. E.g. free_memory, not frees_memory
| @@ -30,7 +30,7 @@ ucp_proto_rndv_get_common_init(const ucp_proto_init_params_t *init_params, | |||
| ucp_context_t *context = init_params->worker->context; | |||
| ucp_proto_multi_init_params_t params = { | |||
| .super.super = *init_params, | |||
| .super.cfg_thresh = ucp_proto_rndv_cfg_thresh(context, rndv_modes), | |||
| .super.cfg_thresh = UCS_MEMUNITS_AUTO, | |||
There was a problem hiding this comment.
Q: with older implementation, the resulting threshold could be 0 or AUTO, while with the new one it is always AUTO.
Is this change on purpose? May it introduce regressions?
There was a problem hiding this comment.
This change is why this patch was created. In master branch if RNDV_SHCEME is set to certain RNDV mode, and this protocol is unavailable, UCX falls back to other RNDV.
It was decide to remove this fall back logic and just don't initialize RNDV modes which are not set in RNDV_SCHEME.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fail protocol initialization if
RNDV_SCHEMEdoesn't contain it's RNDV mode.Why
This simplifies proto initialization logic which significantly affects logic for #9728