Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[select] <selected-value> element violates rules for HTML element names #701

Closed
domenic opened this issue Mar 31, 2023 · 1 comment · Fixed by #710
Closed

[select] <selected-value> element violates rules for HTML element names #701

domenic opened this issue Mar 31, 2023 · 1 comment · Fixed by #710
Assignees
@josepharhar
Labels
select These are issues that relate to the select component

Comments

@domenic
Copy link
Contributor

domenic commented Mar 31, 2023

Although I'm not sure if it's actually an element or not, at least on https://open-ui.org/components/selectmenu/ it's listed as <selected-value>.

If it is an element, it should be <selectedvalue>.
@josepharhar josepharhar added the select These are issues that relate to the select component label Apr 6, 2023
josepharhar added a commit to josepharhar/open-ui that referenced this issue Apr 6, 2023
@josepharhar
Update SelectAnatomy description of parts
ce08772 
fixes openui#701
@josepharhar josepharhar mentioned this issue Apr 6, 2023
Merged
@josepharhar
Copy link
Collaborator

This confused me too when I first read the explainer. It is not an element, just a named slot where the author can provide an element if they want. I am updating the text here: #710

@josepharhar josepharhar self-assigned this Apr 6, 2023
andrico1234 pushed a commit that referenced this issue Apr 8, 2023
@josepharhar
Update SelectAnatomy description of parts (#710)
c892ec9 
* Update SelectAnatomy description of parts

fixes #701

* Rephrase SelectAnatomy parts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josepharhar josepharhar

Labels
select These are issues that relate to the select component
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update SelectAnatomy description of parts josepharhar/open-ui
2 participants
@domenic @josepharhar