Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newer version of Jyutping tables #8

Merged
merged 4 commits into from Apr 7, 2015
Merged

Newer version of Jyutping tables #8

merged 4 commits into from Apr 7, 2015

Conversation

mahiuchun
Copy link
Contributor

@lukhnos
Copy link
Collaborator

lukhnos commented Apr 6, 2015

This looks good except one issue: Have you tried to use the updated jyutping.cin in OpenVanilla? The cin parser in OV uses everything in the definition component, including the comments, and so I think you'll have to remove the inline comments for those to be useful in OV.

@lukhnos lukhnos self-assigned this Apr 6, 2015
@mahiuchun mahiuchun changed the title Make pinyin names more consistent Newer version of Jyutping tables Apr 6, 2015
@mahiuchun
Copy link
Contributor Author

I guess you are right. Fixed.

zaau1 着
zaau2 着
si1 㺨
#
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also have to move those comments out of the %chardef section or remove them entirely–for efficiency reasons OV parses the comments inside %chardef as actual definitions (so the comments become definitions of the key #).

@lukhnos
Copy link
Collaborator

lukhnos commented Apr 7, 2015

@mahiuchun One more issue on the comments inside the %chardef section and this will be good. Thanks!

@mahiuchun
Copy link
Contributor Author

Done

@lukhnos
Copy link
Collaborator

lukhnos commented Apr 7, 2015

@mahiuchun Thank you!

lukhnos added a commit that referenced this pull request Apr 7, 2015
Newer version of Jyutping tables
@lukhnos lukhnos merged commit d35b121 into openvanilla:master Apr 7, 2015
@lukhnos
Copy link
Collaborator

lukhnos commented Jan 16, 2017

The two .cin tables are now built-in as of 1.3.0: https://github.com/openvanilla/openvanilla/releases/tag/1.3.0

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants