New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newer version of Jyutping tables #8
Conversation
This looks good except one issue: Have you tried to use the updated jyutping.cin in OpenVanilla? The cin parser in OV uses everything in the definition component, including the comments, and so I think you'll have to remove the inline comments for those to be useful in OV. |
I guess you are right. Fixed. |
zaau1 着 | ||
zaau2 着 | ||
si1 㺨 | ||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you also have to move those comments out of the %chardef
section or remove them entirely–for efficiency reasons OV parses the comments inside %chardef
as actual definitions (so the comments become definitions of the key #
).
@mahiuchun One more issue on the comments inside the |
Done |
@mahiuchun Thank you! |
Newer version of Jyutping tables
The two .cin tables are now built-in as of 1.3.0: https://github.com/openvanilla/openvanilla/releases/tag/1.3.0 Thanks for the contribution! |
Source: https://github.com/kcwu/xcin25/tree/master/cin/big5