Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use yaml.safe_load for training scripts #215

Closed
ernesto-elsaesser opened this issue Jun 19, 2023 · 1 comment
Closed

Use yaml.safe_load for training scripts #215

ernesto-elsaesser opened this issue Jun 19, 2023 · 1 comment

Comments

@ernesto-elsaesser
Copy link

#142 updated the YAML loading in the download module.

But the training scripts still use yaml.load instead of yaml.safe_load, e.g.:
https://github.com/openvax/mhcflurry/blob/master/mhcflurry/train_allele_specific_models_command.py#L145
https://github.com/openvax/mhcflurry/blob/master/mhcflurry/train_pan_allele_models_command.py#L306

With PyYAML 6.0 (released in 2021) this does not just print a warning, but crashes with an error.
Could you adjust these scripts accordingly?

@timodonnell
Copy link
Contributor

Thanks for noting this - will take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants