Update species.py #281
Closed
Update species.py #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Link to the documentation
iskandr
reviewed
Feb 15, 2023
| @@ -145,7 +145,7 @@ def normalize_species_name(name): | |||
| def find_species_by_name(species_name): | |||
| latin_name = normalize_species_name(species_name) | |||
| if latin_name not in Species._latin_names_to_species: | |||
| raise ValueError("Species not found: %s" % species_name) | |||
| raise ValueError("Species not found: %s; For non-Ensembl Data, see https://github.com/openvax/pyensembl#non-ensembl-data" % species_name) | |||
There was a problem hiding this comment.
Small nit, can you change this to:
raise ValueError("Species not found: %s; for non-Ensembl data see https://github.com/openvax/pyensembl#non-ensembl-data" % (species_name,))
Also, if you increase the library version to 2.2.7 then it will auto-deploy to PyPI on merge
iskandr
added a commit
that referenced
this pull request
Feb 15, 2023
* added fruit fly * also including #281
|
Added in #282 -- thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to the documentation.