Fixing serialization of VaccinePeptide objects #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskandr
requested changes
Feb 28, 2018
| return { | ||
| "mutant_protein_fragment": self.mutant_protein_fragment, | ||
| "mutant_epitope_predictions": self.mutant_epitope_predictions, | ||
| "wildtype_epitope_predictions": self.wildtype_epitope_predictions, | ||
| "epitope_predictions": epitope_predictions, |
There was a problem hiding this comment.
Shouldn't you also serialize/deserialize num_mutant_epitopes_to_keep?
...also, why does that exist?
There was a problem hiding this comment.
it's for one of the outputs, the neoepitope Excel file - I think we maybe used this for Josh Brody's data before?
iskandr
approved these changes
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(and a WUSTL link that just broke)
Fixes #159