Merge pull request #923 from frogonwheels/obd2ecu-positive-rpm

OBD2ECU - Keep RPM positive
openvehicles · Aug 19, 2023 · 7a594f4 · 7a594f4
2 parents 6273de8 + 0f91376
commit 7a594f4
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/vehicle/OVMS.V3/components/obd2ecu/src/obd2ecu.cpp b/vehicle/OVMS.V3/components/obd2ecu/src/obd2ecu.cpp
@@ -583,9 +583,13 @@ void obd2ecu::IncomingFrame(CAN_frame_t* p_frame)
 
           // Test if metric is from a script; if so, don't do the dongle workarounds (script will do this if needed)
           if(m_pidmap[mapped_pid]->GetType() != obd2pid::Script)
-          { metric = metric+jitter;
-            if(StandardMetrics.ms_v_pos_speed->AsFloat() < 1.0) metric = 500+jitter;
-          }
+            {
+            if(StandardMetrics.ms_v_pos_speed->AsFloat() < 1.0)
+              metric = 500;
+            else if (metric < 0)
+              metric = -metric;
+            metric += jitter;
+            }
 
           FillFrame(&r_frame,reply,mapped_pid,metric,pid_format[mapped_pid]);
           m_can->Write(&r_frame);