Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Dockerfile tries to install requirements/base.txt which does not exist #1775

Closed
1 task done
thinhngo-x opened this issue Feb 26, 2024 · 5 comments · Fixed by #1781
Closed
1 task done

[Bug]: Dockerfile tries to install requirements/base.txt which does not exist #1775

thinhngo-x opened this issue Feb 26, 2024 · 5 comments · Fixed by #1781
Assignees
Labels
Docker Dev Good First Issue Issues that can be picked up by someone unfamiliar with the repo and would like to contribute.

Comments

@thinhngo-x
Copy link
Contributor

Describe the bug

Hi,
When trying to open the repo in a container in VSCode, I caught an error.
It seems like the Dockerfile tries to install base.txt which does not exist.
COPY ./requirements/base.txt /tmp/anomalib/requirements/base.txt

Dataset

N/A

Model

N/A

Steps to reproduce the behavior

  1. Clone the repo.
  2. Open it in VSCode Container.

OS information

OS information:

  • OS: Ubuntu 22.04.3 LTS
  • Anomalib version: main branch

Expected behavior

Error when building Docker due to the absence of base.txt file.

Screenshots

No response

Pip/GitHub

pip

What version/branch did you use?

main

Configuration YAML

N/A

Logs

=> ERROR [anomalib_development_env 1/7] COPY ./requirements/base.txt /tm  0.0s
------
 > [anomalib_development_env 1/7] COPY ./requirements/base.txt /tmp/anomalib/requirements/base.txt:
------
[2024-02-26T22:51:14.599Z] Dockerfile-with-features:67
--------------------
  65 |     
  66 |     # Install all anomalib requirements
  67 | >>> COPY ./requirements/base.txt /tmp/anomalib/requirements/base.txt
  68 |     RUN pip install --no-cache-dir -r /tmp/anomalib/requirements/base.txt
  69 |     
--------------------
[2024-02-26T22:51:14.599Z] ERROR: failed to solve: failed to compute cache key: failed to calculate checksum of ref ijzaf3bamlbf0jye5mopicmg3::tuwtj7wj3ie5o7klledci3esh: "/requirements/base.txt": not found
[2024-02-26T22:51:14.617Z] Stop (76759 ms): Run: docker buildx build --load --build-arg BUILDKIT_INLINE_CACHE=1 -f /tmp/devcontainercli-duthngo/container-features/0.54.1-1708987797855/Dockerfile-with-features -t vsc-anomalib-1edfedc330af18949a8666985896c78dce1f1deed07f3ebb7fa856896e519be6 --target dev_containers_target_stage --build-arg _DEV_CONTAINERS_BASE_IMAGE=anomalib_development_env /home/duthngo/anomalib

Code of Conduct

  • I agree to follow this project's Code of Conduct
@thinhngo-x
Copy link
Contributor Author

According to this, I think it requires only changing base.txtto installer.txt.

@samet-akcay samet-akcay added Good First Issue Issues that can be picked up by someone unfamiliar with the repo and would like to contribute. Docker Dev labels Feb 27, 2024
@samet-akcay
Copy link
Contributor

Thanks for reporting this. We have recently merged PR #1748 . The changes should be reflected here in the dockerfile

@samet-akcay
Copy link
Contributor

@thinhngo-x, would you like to create a PR to fix this, or would you prefer us doing it?

@thinhngo-x
Copy link
Contributor Author

I'll submit a PR soon. Thanks

@samet-akcay
Copy link
Contributor

Great, thanks!

thinhngo-x added a commit to thinhngo-x/anomalib that referenced this issue Feb 28, 2024
thinhngo-x added a commit to thinhngo-x/anomalib that referenced this issue Feb 28, 2024
ashwinvaidya17 added a commit that referenced this issue May 15, 2024
* change Dockerfile to fix #1775

* Move export functionality to AnomalyModule

* Updated CHANGELOG

* replace flaky with pytest-rerunfailures

Signed-off-by: Duc Thinh Ngo <duthngo@gmail.com>

* update notebook

Signed-off-by: Duc Thinh Ngo <duthngo@gmail.com>

* resolved comments

* minor fixes

* revert to openvino-export via onnx

* fix changelog

Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>

* minor refactor

Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>

* move InferenceModel to a different file

Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>

* move export mixin to components

Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>

---------

Signed-off-by: Duc Thinh Ngo <duthngo@gmail.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Co-authored-by: Duc Thinh Ngo <duthngo@gmail.com>
Co-authored-by: Thinh D. NGO <56742972+thinhngo-x@users.noreply.github.com>
Co-authored-by: Samet Akcay <samet.akcay@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docker Dev Good First Issue Issues that can be picked up by someone unfamiliar with the repo and would like to contribute.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants