Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃洜 Refactor Normalization #496

Merged
merged 8 commits into from Aug 15, 2022
Merged

Conversation

ashwinvaidya17
Copy link
Collaborator

Description

  • Use a single placeholder for normalization metrics

Changes

  • Refactor (non-breaking change which refactors the code base)

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@ashwinvaidya17 ashwinvaidya17 changed the title Refactor/ashwin/normalization 馃洜 Refactor Normalization Aug 11, 2022
Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this will be a nice improvement. Especially the changes to the inference part are much cleaner than before.

@samet-akcay samet-akcay merged commit d6951eb into main Aug 15, 2022
@samet-akcay samet-akcay deleted the refactor/ashwin/normalization branch August 15, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants