Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Replace keys from benchmarking script #595

Merged
merged 6 commits into from Sep 30, 2022
Merged

✨ Replace keys from benchmarking script #595

merged 6 commits into from Sep 30, 2022

Conversation

ashwinvaidya17
Copy link
Collaborator

Description

  • Replacing keys from benchmarking script will help set dataset from the run configuration. This ensures that all models have the same parameters for dataset.
  • Fixes Set dataset from benchmarking #300

samet-akcay
samet-akcay requested changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments only..

docs/source/tutorials/benchmarking.rst Outdated Show resolved Hide resolved
tests/pre_merge/utils/sweep/__init__.py Outdated Show resolved Hide resolved
@samet-akcay samet-akcay merged commit 2de548d into main Sep 30, 2022
@samet-akcay samet-akcay deleted the ashwin/benchmarking_replace_keys branch September 30, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djdameln djdameln djdameln left review comments

@samet-akcay samet-akcay samet-akcay approved these changes

Assignees
No one assigned
Labels
HPO Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set dataset from benchmarking
3 participants
@ashwinvaidya17 @samet-akcay @djdameln