Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Update coverage tool to codecov for pre-merge #885

Merged
merged 2 commits into from
Feb 3, 2023

Conversation

yunchu
Copy link
Contributor

@yunchu yunchu commented Feb 3, 2023

Description

  • Replaced coverage reporting tool from Codacy to Codecov for the pre-merge job in the workflow

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have added a summary of my changes to the CHANGELOG (not for minor changes, docs and tests).

@github-actions github-actions bot added the CI label Feb 3, 2023
@yunchu yunchu force-pushed the yunchule/coverage-tool-update branch from 06f463d to 926ad91 Compare February 3, 2023 03:21
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@27a2c5f). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #885   +/-   ##
=======================================
  Coverage        ?   86.85%           
=======================================
  Files           ?      165           
  Lines           ?     6331           
  Branches        ?        0           
=======================================
  Hits            ?     5499           
  Misses          ?      832           
  Partials        ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@samet-akcay
Copy link
Contributor

@yunchu, thanks for your PR. Is it possible to do this without setting it up from https://app.codecov.io/gh/openvinotoolkit?

@yunchu
Copy link
Contributor Author

yunchu commented Feb 3, 2023

@yunchu, thanks for your PR. Is it possible to do this without setting it up from https://app.codecov.io/gh/openvinotoolkit?

@samet-akcay AFAIK, for the public repo, it doesn't need to register it and corresponding token is also not required.

@samet-akcay
Copy link
Contributor

@yunchu, thanks for your PR. Is it possible to do this without setting it up from https://app.codecov.io/gh/openvinotoolkit?

@samet-akcay AFAIK, for the public repo, it doesn't need to register it and corresponding token is also not required.

hm, if this is the case, it's good news!

@samet-akcay
Copy link
Contributor

Any idea about how to use codecov badge on the readme file? For codacy, there is this line on the readme
Codacy Badge

To get this, I assume we need to somehow connect to codecov's anomalib dashboard?

@yunchu
Copy link
Contributor Author

yunchu commented Feb 3, 2023

um... it looks like to have signing up to the codecov.io
here is a guild for the badge and need to get into the "setting" menu but cannot see it without sign up to there.
https://docs.codecov.com/docs/status-badges

@samet-akcay
Copy link
Contributor

Yeah, I think we need to add both anomalib and training extensions to codecov to get this. I can only see datumaro and mmdetection repos in codecov.

image

@yunchu
Copy link
Contributor Author

yunchu commented Feb 3, 2023

how about just putting codecov to the README.md? I will try here :)

@github-actions github-actions bot added the Docs label Feb 3, 2023
@yunchu
Copy link
Contributor Author

yunchu commented Feb 3, 2023

I guess the number of the coverage for the default branch should be reported to the codecov to show it correctly.

Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this

Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@samet-akcay samet-akcay merged commit 35a10f2 into main Feb 3, 2023
@samet-akcay samet-akcay deleted the yunchule/coverage-tool-update branch February 3, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants