Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projects #2255

Merged
merged 76 commits into from
Nov 25, 2020
Merged

Projects #2255

merged 76 commits into from
Nov 25, 2020

Conversation

ActiveChooN
Copy link
Contributor

@ActiveChooN ActiveChooN commented Oct 5, 2020

Motivation and context

This PR adds ability to organize annotation tasks into projects

изображение

изображение

partly related to #1278

List of TODOs:

  • Add advanced project selector to the create project page
  • Logger for projects
  • Enable search field for the projects page
  • Changelog, package versions, etc
  • Add tests for API

How has this been tested?

Manually

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@nmanovic
Copy link
Contributor

@ActiveChooN , could you please update the PR and notify me? Just want to check the intermediate stage.

@bsekachev
Copy link
Member

@azhavoro Hi, Could you please look at python files and describe your opinion?

@dvkruchinin
Copy link
Contributor

Hello.
At the moment, I am finishing writing tests for the specified scenario. And faced the problem of determining the system user who created the project.
cvat_projects
Also with the problem of assigning the project to another user. After the assignment and login of the second user, I see the task that was created in the project (on the task list page). But on the project list page, the project is missing.

@ActiveChooN
Copy link
Contributor Author

@bsekachev

I was able to create a task without any labels (first created a project, then a task within the project) and now I cannot open it (what is actually expected). I suppose if a project doesn't have any labels, we should specify them in the first created task (or they are automatically copied from the first moved task according to your intentions)

UPD: Just saw that if after that you update labels in the project, the task could be opened. That's great, but not very obvious. At least I think need to add a relevant message during job loading (now the message looks like "cannot read property 'id' of undefined", what doesn't clarify the root cause.

Agree with you, added custom error with clearer description. Will it be enough in your opinion?

Why cannot we specify bug tracker during creating a project? A task has such the option. Is it planned to be implemented?

Sure. Added

@dvkruchinin

And faced the problem of determining the system user who created the project.

It was a bug, should be fixed now.

@bsekachev
Copy link
Member

Agree with you, added custom error with clearer description. Will it be enough in your opinion?

For the initial version I think it is enough.

cvat-ui/src/actions/projects-actions.ts Outdated Show resolved Hide resolved
cvat-ui/src/actions/projects-actions.ts Outdated Show resolved Hide resolved
@nmanovic
Copy link
Contributor

FAIL: test_api_v1_projects_id_tasks_user (engine.tests.test_rest_api.ProjectListOfTasksAPITestCase)
4204----------------------------------------------------------------------
4205Traceback (most recent call last):
4206  File "/home/django/cvat/apps/engine/tests/test_rest_api.py", line 1012, in test_api_v1_projects_id_tasks_user
4207    self.assertListEqual(
4208AssertionError: Lists differ: ['my multijob task', 'super task'] != ['my multijob task', 'my task #1', 'my task #2', 'super task']

@ActiveChooN
Copy link
Contributor Author

FAIL: test_api_v1_projects_id_tasks_user (engine.tests.test_rest_api.ProjectListOfTasksAPITestCase)
4204----------------------------------------------------------------------
4205Traceback (most recent call last):
4206  File "/home/django/cvat/apps/engine/tests/test_rest_api.py", line 1012, in test_api_v1_projects_id_tasks_user
4207    self.assertListEqual(
4208AssertionError: Lists differ: ['my multijob task', 'super task'] != ['my multijob task', 'my task #1', 'my task #2', 'super task']

@nmanovic, fixed

azhavoro
azhavoro previously approved these changes Nov 23, 2020
bsekachev
bsekachev previously approved these changes Nov 24, 2020
nmanovic
nmanovic previously approved these changes Nov 25, 2020
@nmanovic nmanovic dismissed stale reviews from bsekachev, azhavoro, and themself via 8d82660 November 25, 2020 08:42
@nmanovic nmanovic merged commit 879deb5 into develop Nov 25, 2020
@nmanovic nmanovic deleted the dk/projects branch November 25, 2020 08:44
@jahaniam
Copy link
Contributor

jahaniam commented Jan 6, 2021

I believe automatic annotation for tasks that they are assigned to a project is failing. They show successfully done but the result is not being saved/showed @ActiveChooN

@jahaniam jahaniam mentioned this pull request Jan 6, 2021
@bsekachev
Copy link
Member

@jahaniam , @ActiveChooN

#2644 may be related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants