Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dependent] Cypress test. Project functionality. #2459

Conversation

dvkruchinin
Copy link
Contributor

Motivation and context

Depend on #2255
Cypress test to check base actions on project.
Functionality for creating a project. Some necessary checks after executing the cypress command are moved to the body of the cypress command.

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@coveralls
Copy link

coveralls commented Nov 20, 2020

Coverage Status

Coverage increased (+0.8%) to 63.038% when pulling 6e832a7 on dvkruchinin:dkru/base-cypress-test-project-functionality into 37a8212 on openvinotoolkit:develop.

Copy link
Contributor

@ActiveChooN ActiveChooN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Have another one test case to add.

  1. Assign second task created in the project to admin user
  2. Login with second user
  3. Go to tasks page, there is only should be first task from project

@@ -61,4 +61,24 @@ describe('Delete users and tasks created during the test run.', () => {
}
});
});
it('Get a list of projects and delete them all', () => {
cy.request({
url: '/api/v1/projects?page_size=1000',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url: '/api/v1/projects?page_size=1000',
url: '/api/v1/projects?page_size=all',

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I applied this in a new commit

@dvkruchinin
Copy link
Contributor Author

@ActiveChooN

Have another one test case to add.

  1. Assign second task created in the project to admin user
  2. Login with second user
  3. Go to tasks page, there is only should be first task from project

Test case added. Also I move cypress command for projects functionality to different command file (commands_projects.js). I think it`s would be better for readability.

@ActiveChooN
Copy link
Contributor

LGTM,

@bsekachev, could you please merge PR?

@nmanovic nmanovic merged commit 75d2826 into cvat-ai:develop Nov 26, 2020
@dvkruchinin dvkruchinin deleted the dkru/base-cypress-test-project-functionality branch November 26, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants