Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the error message for datum stats to be more user friendly #1069

Merged
merged 3 commits into from
Jul 3, 2023

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Jun 28, 2023

Summary

  • Ticket no. 112203
  • Improve the error message for users encountered in the following CLI use case:
(datumaro) vinnamki@vinnamki:~/datumaro/ws_datum/stats$ datum project create
(datumaro) vinnamki@vinnamki:~/datumaro/ws_datum/stats$ datum project import -n eurosat -f imagenet_txt /home/vinnamki/datumaro/tfdseurosat-imagenet_txt.1
(datumaro) vinnamki@vinnamki:~/datumaro/ws_datum/stats$ datum project import -n uc_merced -f imagenet_txt /home/vinnamki/datumaro/tfdsuc_merced-imagenet_txt

(Before)

(datumaro) vinnamki@vinnamki:~/datumaro/ws_datum/stats$ datum stats
2023-06-28 17:09:27,574 ERROR: Failed to parse revspec:
  Merging of datasets with different categories is only allowed in 'merge' command.
  Path project doesn't exist

(After)

(datumaro) vinnamki@vinnamki:~/datumaro/ws_datum/stats$ datum stats
2023-06-28 17:55:20,580 ERROR: There are more than two sources with heterogeneous categories in the project. This prevents computing the statistics of the merged one. Please specify one of the sources in the project (['eurosat', 'uc_merced']), such as `datum stats eurosat`

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim marked this pull request as ready for review June 28, 2023 08:54
@vinnamkim vinnamkim requested review from a team as code owners June 28, 2023 08:54
@vinnamkim vinnamkim added the ENHANCE Enhancement of existing features label Jun 28, 2023
@vinnamkim vinnamkim added this to the 1.4.0 milestone Jun 28, 2023
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
sooahleex
sooahleex previously approved these changes Jun 29, 2023
Copy link
Contributor

@sooahleex sooahleex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

jihyeonyi
jihyeonyi previously approved these changes Jun 30, 2023
wonjuleee
wonjuleee previously approved these changes Jun 30, 2023
Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinnamkim vinnamkim merged commit 6070ff2 into openvinotoolkit:develop Jul 3, 2023
4 checks passed
@vinnamkim vinnamkim deleted the enhance/ux-datum-stats branch July 3, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENHANCE Enhancement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants