Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test benchmarker #311

Merged
merged 4 commits into from Jan 23, 2024
Merged

Test benchmarker #311

merged 4 commits into from Jan 23, 2024

Conversation

igor-davidyuk
Copy link
Collaborator

This PR introduces unit tests and nightly integration tests for the Benchmarking package.

@igor-davidyuk
add unit tests
3d838e7 
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
@igor-davidyuk
add nightly test
8cd588f 
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
@igor-davidyuk igor-davidyuk marked this pull request as ready for review January 22, 2024 08:48
ljcornel
ljcornel reviewed Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@ljcornel ljcornel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, many thanks! I just have some minor comments on the PR itself.

I'm thinking maybe it would be good to add a benchmarking nightly test for a Detection->Classification task-chain project as well. If we limit the algo's used to 2 for each task and include the default algorithms, then the additional overhead required for training won't be that large.

tests/nightly/test_classification.py Outdated Show resolved Hide resolved
tests/nightly/test_classification.py Outdated Show resolved Hide resolved
igor-davidyuk and others added 2 commits January 22, 2024 13:59
@igor-davidyuk @ljcornel
Update tests/nightly/test_classification.py
4cf0145 
Co-authored-by: Ludo Cornelissen <ludo.cornelissen@intel.com>
@igor-davidyuk
add nightly test for detection to classification
8630b8a 
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
@igor-davidyuk
Copy link
Collaborator Author

This looks great, many thanks! I just have some minor comments on the PR itself.

I'm thinking maybe it would be good to add a benchmarking nightly test for a Detection->Classification task-chain project as well. If we limit the algo's used to 2 for each task and include the default algorithms, then the additional overhead required for training won't be that large.

I added another nightly test for the Detection->Classification task-chain project

@ljcornel ljcornel merged commit fc1d52b into openvinotoolkit:main Jan 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljcornel ljcornel ljcornel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@igor-davidyuk @ljcornel