Async kserve samples #1641
Merged
Async kserve samples #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkalinowski
reviewed
Jan 2, 2023
dkalinowski
reviewed
Jan 2, 2023
dkalinowski
reviewed
Jan 2, 2023
dtrawins
reviewed
Jan 3, 2023
mzegla
reviewed
Jan 3, 2023
Comment on lines
154
to
160
| data.append(triton_client.async_infer( | ||
| model_name=args.get( | ||
| 'pipeline_name') if is_pipeline_request else args.get('model_name'), | ||
| inputs=inputs, | ||
| outputs=outputs)) | ||
|
|
||
| output = data[x].get_result().as_numpy(args['output_name']) |
There was a problem hiding this comment.
Why for http there's a different approach than with grpc sample? This part calls async_infer method, but it looks like effectively it's synchronous as we call get_result() right after inference is scheduled.
There was a problem hiding this comment.
There doesn't seem to be a callback equivalent in the http client https://github.com/triton-inference-server/client/blob/1a98fe0cd6b18ded726ada052f1bab06ab07ceb1/src/python/library/tritonclient/http/__init__.py#L1494
There was a problem hiding this comment.
You're right. Let's stick to this version then.
mzegla
approved these changes
Jan 4, 2023
dtrawins
approved these changes
Jan 5, 2023
dkalinowski
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.