Override config metrics enable with cli #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrawins
reviewed
Jan 11, 2023
|
check also ovms --help output and make sure metrics params are in server settings section. |
|
Missing ticket ID and description |
dkalinowski
reviewed
Jan 23, 2023
dkalinowski
reviewed
Jan 23, 2023
dkalinowski
reviewed
Jan 23, 2023
dkalinowski
reviewed
Jan 23, 2023
| "Flag enabling metrics endpoint on rest_port.", | ||
| cxxopts::value<bool>()->default_value("false"), | ||
| "METRICS") | ||
| ("metrics_list", |
There was a problem hiding this comment.
Should we include information that when used, config.json cannot contain metric configuration? @dtrawins
There was a problem hiding this comment.
I would keep it short but indeed documentation should be adjusted in https://github.com/openvinotoolkit/model_server/blob/develop/docs/parameters.md
A note in https://github.com/openvinotoolkit/model_server/blob/main/docs/metrics.md could be also useful that configuration can not be duplicated.
bstrzele
force-pushed
the
cli_metrics_enable
branch
from
24ec16e
to
aaceb69
Compare
dkalinowski
approved these changes
Jan 31, 2023
dtrawins
reviewed
Jan 31, 2023
dtrawins
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows using metrics_enable param in CLI even with config. CLI will overwrite config setting if defined. Added warning in the logs.
JIRA:CVS-99880