Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Good First Issue] [NNCF] Make NNCF common pruning code pass mypy checks #2494

Open
vshampor opened this issue Jan 19, 2024 · 14 comments
Open
Assignees
Labels
good first issue Good for newcomers

Comments

@vshampor
Copy link
Contributor

This is exactly like #2495 (see the description and tasks there), but the target code path for this one is nncf/common/pruning instead of nncf/common/graph.

@Lymah123
Copy link

Hi @vshampor , can I work on this?

@rkazants
Copy link

Hi @Lymah123, the task is assigned to you.

Best regards,
Roman

@avitial avitial added the good first issue Good for newcomers label Jan 23, 2024
@p-wysocki
Copy link
Contributor

Hello @Lymah123, are you still working on that issue?

@RitikaxShakya
Copy link

.take

Copy link

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@ilya-lavrenov ilya-lavrenov transferred this issue from openvinotoolkit/openvino Feb 20, 2024
@p-wysocki
Copy link
Contributor

Hello @RitikaxShakya, are you still working on that issue?

@RitikaxShakya
Copy link

yes, i am looking into the issue

@p-wysocki
Copy link
Contributor

Please let us know if there are any updates.

@RitikaxShakya
Copy link

Hello! Sorry for late reply. I've installed mypy and now I'll create/update the mypy.ini configuration file in the project's root directory to tailor Mypy's settings to our specific needs.

@RitikaxShakya
Copy link

RitikaxShakya commented Mar 17, 2024

Hello! This is just an update:
so i found these many errors:
image
And now I am on my way solving these so reached this much :
image

@RitikaxShakya
Copy link

Hello! @vshampor @p-wysocki I would like to know how I ensure or test that my changes in the code are not changing logic. I am using pytest but is there anything else, please let me know.

Thank you!

@vshampor
Copy link
Contributor Author

Greetings, @RitikaxShakya! Indeed, you should orient yourself on the pytest runs. These are available as corresponding test-* Makefile targets in the repo root, and the same targets are being run as PR precommit checks.

@RitikaxShakya
Copy link

@p-wysocki Hello! i raised a PR for this issue. Please take a look whenever possible. Thank you!

@p-wysocki
Copy link
Contributor

Thank you for your contribution! cc @vshampor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: In Review
Development

No branches or pull requests

6 participants