Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SQ algorithm ports usage #2672

Merged
merged 1 commit into from
May 28, 2024

Conversation

KodiaqQ
Copy link
Collaborator

@KodiaqQ KodiaqQ commented May 8, 2024

Changes

  • Fixed SmoothQuant algorithm to work with Split ports correctly;

Reason for changes

  • Bugfix

Related tickets

  • 140351

Tests

@KodiaqQ KodiaqQ requested a review from alexsu52 May 8, 2024 13:08
@KodiaqQ KodiaqQ requested a review from a team as a code owner May 8, 2024 13:08
@github-actions github-actions bot added the NNCF PTQ Pull requests that updates NNCF PTQ label May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 29.87%. Comparing base (359447b) to head (44c5617).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2672       +/-   ##
============================================
- Coverage    62.02%   29.87%   -32.16%     
============================================
  Files          495      495               
  Lines        45969    45970        +1     
============================================
- Hits         28514    13735    -14779     
- Misses       17455    32235    +14780     
Files Coverage Δ
.../quantization/algorithms/smooth_quant/algorithm.py 21.84% <0.00%> (-72.31%) ⬇️

... and 264 files with indirect coverage changes

Flag Coverage Δ
COMMON ?
ONNX ?
OPENVINO ?
TENSORFLOW 29.87% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 76.35% <ø> (-12.10%) ⬇️
torch 0.01% <ø> (-32.84%) ⬇️
tensorflow 93.74% <ø> (ø)
onnx 0.00% <ø> (-93.07%) ⬇️
openvino 0.00% <ø> (-94.25%) ⬇️
ptq 15.18% <0.00%> (-65.49%) ⬇️

@KodiaqQ
Copy link
Collaborator Author

KodiaqQ commented May 27, 2024

@alexsu52, please, review.

Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexsu52 alexsu52 merged commit eb377e6 into openvinotoolkit:develop May 28, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF PTQ Pull requests that updates NNCF PTQ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants