【PaddlePaddle Hackathon 4】add paddle grid_sampler op #15869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patrick-Star125
changed the title
Patrick-Star125
changed the title
|
@OpenVINO-dev-contest could you review this pr please? |
ilya-lavrenov
added
ExternalPR
Hi, Im ok with the implementation, Did you refer to openvino's onnx frontend ? if yes, pls add the link into this conversion and it will be helpful for other reviewer to understand your solution more easily. thanks |
OpenVINO-dev-contest
approved these changes
Mar 10, 2023
xczhai
requested changes
Mar 10, 2023
src/frontends/paddle/tests/test_models/gen_scripts/generate_grid_sampler.py
Outdated
Show resolved
Hide resolved
|
Hi @Patrick-Star125 ,
|
|
Got it, test sample with dynami shape has been added. |
xczhai
approved these changes
Mar 13, 2023
xczhai
reviewed
Apr 24, 2023
| auto data = node.get_input("X"); | ||
| auto grid = node.get_input("Grid"); | ||
| default_opset::GridSample::Attributes attributes{}; | ||
|
|
There was a problem hiding this comment.
please correct the code format here as log reports.
|
Can one of the admins verify this patch? |
ceciliapeng2011
approved these changes
May 12, 2023
ceciliapeng2011
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
add grid_sample operation in Paddle front end
Reference:
unit-test