Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed IndexError list index out of range for Squeeze #22326

Merged
merged 10 commits into from Jan 24, 2024

Conversation

abhinav231-valisetti
Copy link
Contributor

@abhinav231-valisetti abhinav231-valisetti commented Jan 22, 2024

Details:

  • I have added a check to ensure the list is not empty before accessing its elements, addressing the IndexError issue in the Squeeze operation.

Issue -
#22078

@abhinav231-valisetti abhinav231-valisetti requested a review from a team as a code owner January 22, 2024 17:28
@github-actions github-actions bot added the category: Python API OpenVINO Python bindings label Jan 22, 2024
@abhinav231-valisetti abhinav231-valisetti changed the title Fixed IndexError list index out of range for Squeeze #22078 Fixed IndexError list index out of range for Squeeze Jan 22, 2024
@rkazants rkazants added ExternalPR External contributor category: TF FE OpenVINO TensorFlow FrontEnd labels Jan 23, 2024
Copy link
Contributor

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhinav231-valisetti, please update https://github.com/openvinotoolkit/openvino/blob/master/tests/model_hub_tests/tf_hub_tests/precommit_models with a model for which you did this fix so your fix will be validated in the pre-commit:

delf,https://www.kaggle.com/models/google/delf/frameworks/tensorFlow1/variations/delf/versions/1

And please remove skip and xfail marks for this issue 129232 IndexError list index out of range for Squeeze in https://github.com/openvinotoolkit/openvino/blob/master/tests/model_hub_tests/tf_hub_tests/nightly_models for nightly validation.

Best regards,
Roman

@rkazants rkazants added this to the 2024.0 milestone Jan 23, 2024
@p-wysocki
Copy link
Contributor

build_jenkins

@github-actions github-actions bot removed the category: TF FE OpenVINO TensorFlow FrontEnd label Jan 23, 2024
- Added a Model in the precommit_models for precommit validation.
- Removed skip and xfail marrks for the issue (129232 IndexError list
  index out of range for Squeeze)
- Added explicilty return None in node_decoder.py
@abhinav231-valisetti
Copy link
Contributor Author

abhinav231-valisetti commented Jan 23, 2024

Hi @rkazants I have performed the following changes in the new commit,

  1. Added a Model in the precommit_models for precommit validation.
    mmt/data_cc,https://www.kaggle.com/models/deepmind/mmt/frameworks/tensorFlow1/variations/data-cc/versions/1
  2. Removed skip and xfail marrks for the issue (129232 IndexError list index out of range for Squeeze) in nighty_models.
  3. Added explicilty return None in node_decoder.py

*** Below model which i used to fix the current issue initially is giving me an error while loading the modal using tensowflow_hub. So i have used another model from the nighty models to move forward.
delf,https://www.kaggle.com/models/google/delf/frameworks/tensorFlow1/variations/delf/versions/1

tests/model_hub_tests/tf_hub_tests/nightly_models Outdated Show resolved Hide resolved
tests/model_hub_tests/tf_hub_tests/nightly_models Outdated Show resolved Hide resolved
tests/model_hub_tests/tf_hub_tests/nightly_models Outdated Show resolved Hide resolved
tests/model_hub_tests/tf_hub_tests/nightly_models Outdated Show resolved Hide resolved
tests/model_hub_tests/tf_hub_tests/nightly_models Outdated Show resolved Hide resolved
tests/model_hub_tests/tf_hub_tests/nightly_models Outdated Show resolved Hide resolved
tests/model_hub_tests/tf_hub_tests/nightly_models Outdated Show resolved Hide resolved
tests/model_hub_tests/tf_hub_tests/nightly_models Outdated Show resolved Hide resolved
tests/model_hub_tests/tf_hub_tests/nightly_models Outdated Show resolved Hide resolved
tests/model_hub_tests/tf_hub_tests/nightly_models Outdated Show resolved Hide resolved
@rkazants
Copy link
Contributor

build_jenkins

@rkazants
Copy link
Contributor

build_jenkins

@rkazants
Copy link
Contributor

build_jenkins

@rkazants rkazants enabled auto-merge (squash) January 24, 2024 05:03
@rkazants rkazants merged commit 51cbbab into openvinotoolkit:master Jan 24, 2024
101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Python API OpenVINO Python bindings category: TF FE OpenVINO TensorFlow FrontEnd ExternalPR External contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Good First Issue][TF FE]: Fix IndexError list index out of range for Squeeze
4 participants