Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PagedAttention tests to Precommit #24634

Merged
merged 12 commits into from
May 30, 2024
Merged

Add PagedAttention tests to Precommit #24634

merged 12 commits into from
May 30, 2024

Conversation

CuriousPanCake
Copy link
Contributor

@CuriousPanCake CuriousPanCake commented May 22, 2024 •
edited
Loading

Details:

Add tests for the SPDAToPagedAttention transformation to Precommit

  1. Check if PagedAttentionExtension node appeared in the model after the transformation
  2. Check 2 last dimensions of 'key_cache.' and 'value_cache.' inputs to be static.

Tickets:

Signed-off-by: Andrii Staikov andrii.staikov@intel.com

@github-actions github-actions bot added category: TF FE OpenVINO TensorFlow FrontEnd category: PyTorch FE OpenVINO PyTorch Frontend labels May 22, 2024
rkazants
rkazants previously requested changes May 23, 2024
View reviewed changes
Copy link
Contributor

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incorrect structure

@rkazants rkazants self-assigned this May 23, 2024
@github-actions github-actions bot added category: CI OpenVINO public CI github_actions Pull requests that update GitHub Actions code labels May 24, 2024
@CuriousPanCake CuriousPanCake changed the title wip Add PagedAttention tests to Precommit (WIP) May 24, 2024
@github-actions github-actions bot added the category: dependency_changes Pull requests that update a dependency file label May 24, 2024
@rkazants rkazants dismissed their stale review May 25, 2024 11:02

nothing critical

@github-actions github-actions bot removed the category: TF FE OpenVINO TensorFlow FrontEnd label May 27, 2024
@itikhono itikhono marked this pull request as ready for review May 27, 2024 10:36
@itikhono itikhono requested review from a team as code owners May 27, 2024 10:36
rkazants
rkazants requested changes May 29, 2024
View reviewed changes
Copy link
Contributor

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to clean up requirements and dirty code

rkazants
rkazants requested changes May 29, 2024
View reviewed changes
Copy link
Contributor

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment for tokenizers is still not resolved

@ilya-lavrenov ilya-lavrenov added this pull request to the merge queue May 30, 2024
Merged via the queue into openvinotoolkit:master with commit be5fd8b May 30, 2024
117 checks passed
@ilya-lavrenov ilya-lavrenov mentioned this pull request Jun 24, 2024
Merged
2 tasks
allnes pushed a commit to allnes/openvino that referenced this pull request Jun 27, 2024
@CuriousPanCake @allnes
Add PagedAttention tests to Precommit (openvinotoolkit#24634)
99be31f 
### Details:
Add tests for the SPDAToPagedAttention transformation to Precommit
1) Check if PagedAttentionExtension node appeared in the model after the
transformation
2) Check 2 last dimensions of 'key_cache.' and 'value_cache.' inputs to
be static.

### Tickets:
 - [CVS-138943](https://jira.devtools.intel.com/browse/CVS-138943)

Signed-off-by: Andrii Staikov <andrii.staikov@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itikhono itikhono itikhono approved these changes

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

@rkazants rkazants rkazants approved these changes

@AlexKoff88 AlexKoff88 Awaiting requested review from AlexKoff88 AlexKoff88 is a code owner automatically assigned from openvinotoolkit/openvino-configuration-mgmt

@artanokhov artanokhov Awaiting requested review from artanokhov artanokhov is a code owner automatically assigned from openvinotoolkit/openvino-configuration-mgmt

@mmikolajcz mmikolajcz Awaiting requested review from mmikolajcz mmikolajcz is a code owner automatically assigned from openvinotoolkit/openvino-pytorch-frontend-maintainers

@cavusmustafa cavusmustafa Awaiting requested review from cavusmustafa cavusmustafa is a code owner automatically assigned from openvinotoolkit/openvino-pytorch-frontend-maintainers

@slyalin slyalin Awaiting requested review from slyalin

@akashchi akashchi Awaiting requested review from akashchi

@popovaan popovaan Awaiting requested review from popovaan

Assignees

@rkazants rkazants

@akashchi akashchi

Labels
category: CI OpenVINO public CI category: dependency_changes Pull requests that update a dependency file category: PyTorch FE OpenVINO PyTorch Frontend github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
2024.3
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@CuriousPanCake @ilya-lavrenov @itikhono @slyalin @rkazants @akashchi