Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TF FE] Support AdjustHue operation #24769

Merged
merged 53 commits into from
Jun 2, 2024

Conversation

duydl
Copy link
Contributor

@duydl duydl commented May 29, 2024

Details:

Tickets:

Sorry, commit history is wrong, should have created branch from latest upstream.

duydl and others added 30 commits May 14, 2024 18:56
@rkazants rkazants enabled auto-merge May 30, 2024 17:30
@rkazants rkazants disabled auto-merge May 30, 2024 19:08
@rkazants
Copy link
Contributor

build_jenkins

@rkazants
Copy link
Contributor

build_jenkins

@rkazants
Copy link
Contributor

build_jenkins

@rkazants rkazants enabled auto-merge May 31, 2024 17:01
@rkazants
Copy link
Contributor

build_jenkins

@duydl
Copy link
Contributor Author

duydl commented Jun 1, 2024

@rkazants I just saw #24791, #24792

Should this PR be noted also for the new location of the converter util functions after merging?

@rkazants
Copy link
Contributor

rkazants commented Jun 1, 2024

R be noted also for the new location of the converter util functions after m

I think it will not be a big problem for a contributor to find it:) The main part has been already covered by you.

Best regards,
Roman

auto-merge was automatically disabled June 1, 2024 19:25

Head branch was pushed to by a user without write access

@rkazants
Copy link
Contributor

rkazants commented Jun 1, 2024

@duydl, please do not rebase and do not change your code changes. All is fine with PR. Now we have infra problems and let us anticipate a fix to merge.

Best regards,
Roman

@rkazants
Copy link
Contributor

rkazants commented Jun 1, 2024

build_jenkins

@duydl
Copy link
Contributor Author

duydl commented Jun 1, 2024

Sorry for wasting checks running. I know failed checks now not related to PR. Just fix one var in adjust_hue_op that still has "saturation" in naming.

@ilya-lavrenov ilya-lavrenov merged commit 5ea0e96 into openvinotoolkit:master Jun 2, 2024
112 of 116 checks passed
allnes pushed a commit to allnes/openvino that referenced this pull request Jun 27, 2024
### Details:
- Adapt from openvinotoolkit#24511 . Converting code repeated. Instead import from
there?
- Converting logic a little different from
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/core/kernels/image/adjust_hue_op.cc
. Maybe less efficient?

### Tickets:
 - openvinotoolkit#24033 

Sorry, commit history is wrong, should have created branch from latest
upstream.

---------

Co-authored-by: Roman Kazantsev <roman.kazantsev@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: docs OpenVINO documentation category: TF FE OpenVINO TensorFlow FrontEnd category: TFL FE OpenVINO TensorFlow Lite FrontEnd ExternalPR External contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Good First Issue][TF FE]: Support AdjustHue operation for TensorFlow
4 participants