Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added python bindings for tensor descriptor #25083

Merged
merged 21 commits into from
Jun 18, 2024
Merged

Added python bindings for tensor descriptor #25083

merged 21 commits into from
Jun 18, 2024

Conversation

amkarn258
Copy link
Contributor

@amkarn258 amkarn258 commented Jun 17, 2024 •
edited
Loading

Details:

Bindings of methods get_lower_value/set, get_upper_value/set and get_value_symbol/set added for tensor descriptor along with their respective tests.

Tickets:

  • 140495

Closes Issue #24909

@amkarn258
added python bindings for get_lower_value/set, get_upper_value/set an…
edd0dec 
…d get_value_symbol/set along with tests for get_lower_value/set and get_upper_value/set
@amkarn258
Tests added for get_value_symbol/set
e304a85
@amkarn258 amkarn258 requested a review from a team as a code owner June 17, 2024 20:43
@github-actions github-actions bot added the category: Python API OpenVINO Python bindings label Jun 17, 2024
@sys-openvino-ci sys-openvino-ci added the ExternalPR External contributor label Jun 17, 2024
@amkarn258 amkarn258 mentioned this pull request Jun 17, 2024
Closed
@mlukasze mlukasze linked an issue Jun 18, 2024 that may be closed by this pull request
[Good First Issue]: Add python bindings for TensorDescriptor #24909
Closed
@p-wysocki
Copy link
Contributor

build_jenkins

p-wysocki
p-wysocki approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@p-wysocki p-wysocki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, looks good to me! @akuporos do you think we need any documentation updates as a follow up?

@amkarn258 the Python linter is failing, you can look through the logs or reproduce the issue locally, you can use our docs: https://github.com/openvinotoolkit/openvino/blob/master/src/bindings/python/docs/test_examples.md#check-the-codestyle-of-python-api

src/bindings/python/tests/test_runtime/test_input_node.py Outdated Show resolved Hide resolved
@akuporos
Copy link
Contributor

Hi @amkarn258,

Thank you for your contribution!

In order to fix C++ code style, please run next commands:
If you don't have installed clang-format-15, so let's install it:
sudo apt --assume-yes install clang-format-15
After that run cmake with -DENABLE_PROFILING_ITT=ON -DSELECTIVE_BUILD=COLLECT in order to enable codestyle check for ITT collector:
cmake -DENABLE_PYTHON=ON -DENABLE_TESTS=ON -DENABLE_PROFILING_ITT=ON -DSELECTIVE_BUILD=COLLECT -B build
And create code style diff:
cmake --build build --target clang_format_fix_all -j8

@amkarn258 amkarn258 requested a review from a team as a code owner June 18, 2024 10:50
@github-actions github-actions bot added the category: dependency_changes Pull requests that update a dependency file label Jun 18, 2024
amkarn258 and others added 3 commits June 18, 2024 16:24
@amkarn258 @p-wysocki
Update src/bindings/python/tests/test_runtime/test_input_node.py
2860175 
Co-authored-by: Przemyslaw Wysocki <przemyslaw.wysocki@intel.com>
@amkarn258 @akuporos
Update src/bindings/python/src/pyopenvino/graph/descriptors/tensor.cpp
722e2e9 
Co-authored-by: Anastasia Kuporosova <anastasia.kuporosova@intel.com>
@amkarn258 @akuporos
Update src/bindings/python/src/pyopenvino/graph/descriptors/tensor.cpp
d5fe985 
Co-authored-by: Anastasia Kuporosova <anastasia.kuporosova@intel.com>
amkarn258 and others added 8 commits June 18, 2024 16:24
@amkarn258 @akuporos
Update src/bindings/python/src/pyopenvino/graph/descriptors/tensor.cpp
d31c409 
Co-authored-by: Anastasia Kuporosova <anastasia.kuporosova@intel.com>
@amkarn258 @akuporos
Update src/bindings/python/src/pyopenvino/graph/descriptors/tensor.cpp
a5c54dd 
Co-authored-by: Anastasia Kuporosova <anastasia.kuporosova@intel.com>
@amkarn258 @akuporos
Update src/bindings/python/tests/test_runtime/test_input_node.py
eecfc93 
Co-authored-by: Anastasia Kuporosova <anastasia.kuporosova@intel.com>
@amkarn258 @akuporos
Update src/bindings/python/tests/test_runtime/test_output_node.py
70d3e34 
Co-authored-by: Anastasia Kuporosova <anastasia.kuporosova@intel.com>
@amkarn258 @akuporos
Update src/bindings/python/tests/test_runtime/test_output_node.py
feac46f 
Co-authored-by: Anastasia Kuporosova <anastasia.kuporosova@intel.com>
@amkarn258 @akuporos
Update src/bindings/python/src/pyopenvino/graph/descriptors/tensor.cpp
3b6acdf 
Co-authored-by: Anastasia Kuporosova <anastasia.kuporosova@intel.com>
@amkarn258 @akuporos
Update src/bindings/python/src/pyopenvino/graph/descriptors/tensor.cpp
c6f4f9a 
Co-authored-by: Anastasia Kuporosova <anastasia.kuporosova@intel.com>
@amkarn258 @akuporos
Update src/bindings/python/tests/test_runtime/test_output_node.py
d446ba2 
Co-authored-by: Anastasia Kuporosova <anastasia.kuporosova@intel.com>
@amkarn258
Revert "cpp code style fix"
38dadce 
This reverts commit 37c3035.
@github-actions github-actions bot removed the category: dependency_changes Pull requests that update a dependency file label Jun 18, 2024
akuporos
akuporos approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@akuporos akuporos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@akuporos
Copy link
Contributor

build_jenkins

@akuporos akuporos added this to the 2024.3 milestone Jun 18, 2024
@akuporos akuporos enabled auto-merge June 18, 2024 15:20
@akuporos akuporos added this pull request to the merge queue Jun 18, 2024
Merged via the queue into openvinotoolkit:master with commit ddc72a4 Jun 18, 2024
118 checks passed
allnes pushed a commit to allnes/openvino that referenced this pull request Jun 27, 2024
@amkarn258 @p-wysocki
@akuporos @allnes
Added python bindings for tensor descriptor (openvinotoolkit#25083)
806d364 
### Details:
Bindings of methods get_lower_value/set, get_upper_value/set and
get_value_symbol/set added for tensor descriptor along with their
respective tests.

### Tickets:
 - *140495*

Closes Issue
[openvinotoolkit#24909](openvinotoolkit#24909)

---------

Co-authored-by: Przemyslaw Wysocki <przemyslaw.wysocki@intel.com>
Co-authored-by: Anastasia Kuporosova <anastasia.kuporosova@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akuporos akuporos akuporos approved these changes

@p-wysocki p-wysocki p-wysocki approved these changes

Assignees
No one assigned
Labels
category: Python API OpenVINO Python bindings ExternalPR External contributor
Projects
None yet
Milestone
2024.3
Development

Successfully merging this pull request may close these issues.

[Good First Issue]: Add python bindings for TensorDescriptor
4 participants
@amkarn258 @p-wysocki @akuporos @sys-openvino-ci