PassManager refactoring #25637
PassManager refactoring #25637
Conversation
github-actions
bot
added
category: Core
github-actions
bot
added
the
category: LP transformations
github-actions
bot
added
category: IR FE
|
|
||
| ov::pass::Manager::~Manager() = default; | ||
| if (off.count(val)) { |
There was a problem hiding this comment.
need to apply "to_lower"
| //// \brief Construct Manager with shared PassConfig instance | ||
| explicit Manager(std::shared_ptr<PassConfig> pass_config); | ||
| explicit Manager(std::shared_ptr<PassConfig> pass_config, std::string name = "PassManager"); |
There was a problem hiding this comment.
UnnamedManager by default
| if (is_pass_manager) { | ||
| std::cout << "PassManager: "; | ||
| } else { | ||
| std::cout << "Transformation: "; |
There was a problem hiding this comment.
do we need to write to stdout these strings?
There was a problem hiding this comment.
should it be parsed? if yes, it should be send to file (if file path passed)
| continue; | ||
| bool is_pass_manager = name == m_manager_name; | ||
| if (is_pass_manager) { | ||
| std::cout << "PassManager " << m_manager_name << " started: " << std::endl; |
There was a problem hiding this comment.
do we need this to stdout?
There was a problem hiding this comment.
should it be parsed? if yes, it should be send to file (if file path passed)
| if (is_pass_manager) { | ||
| std::cout << "PassManager: "; | ||
| } else { | ||
| std::cout << "Transformation: "; |
There was a problem hiding this comment.
should it be parsed? if yes, it should be send to file (if file path passed)
| << (applied ? "1;" : "0;") << std::endl; | ||
| } else { | ||
| m_file << "t;" << name << ";" << m_manager_name << ";" << stopwatch.get_timer_value().count() << ";" | ||
| << (applied ? "1" : "0") << ";" << std::endl; |
There was a problem hiding this comment.
python3 csv parser recognizes the last field - field after the last ';'. So currently the last field will be empty. It is not needed.
Details:
Tickets: