Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MO] relax condition for casting into FP16 #8083

Closed
wants to merge 13 commits into from
Closed

[MO] relax condition for casting into FP16 #8083

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ecf582b
relaxed condition for casting into FP16
pavel-esir Oct 19, 2021
931ac2d
added warning fro clipping into zero, added unit-tests for warnings w…
pavel-esir Oct 22, 2021
2ad2131
Merge remote-tracking branch 'upstream/master' into relax_fp16_limit_…
pavel-esir Nov 11, 2021
e24d657
corrected 1D assert in Select for OOB
pavel-esir Nov 10, 2021
2c7bbf8
corrected ChangeOutputTypeAttributes.py
pavel-esir Nov 11, 2021
85ff1c8
added DivisionToZeroFP16Resolver.py
pavel-esir Nov 11, 2021
39fb150
added unit-tests for DivisionToZeroFP16Resolver.py, some improvements
pavel-esir Nov 12, 2021
5e0e5eb
reused convert_blob
pavel-esir Nov 12, 2021
a6ca2a7
Merge remote-tracking branch 'upstream/master' into relax_fp16_limit_…
pavel-esir Nov 18, 2021
048d85d
Revert "added unit-tests for DivisionToZeroFP16Resolver.py, some impr…
pavel-esir Nov 18, 2021
5840a6e
Revert "added DivisionToZeroFP16Resolver.py"
pavel-esir Nov 18, 2021
b20d475
Revert "corrected 1D assert in Select for OOB"
pavel-esir Dec 3, 2021
9426c8b
Merge remote-tracking branch 'upstream/master' into relax_fp16_limit_…
pavel-esir Dec 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions model-optimizer/extensions/back/ChangeOutputTypeAttributes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,12 +73,13 @@ def assert_that_is_castable_to_fp16(node: Node):
val = node.in_port(i).data.get_value()
if val is None:
return

if np.any(val > np.finfo(np.float16).max) or np.any(val < np.finfo(np.float16).min):
raise Error("Try to convert with --data_type=FP32 argument. "
"This model can not be converted to FP16 precision, since "
"'{}' node value {} exceeds FP16 allowed limits: [{}, {}]"
.format(node_name, val, np.finfo(np.float16).min, np.finfo(np.float16).max))
# some models have -Inf values but nevertheless are correctly inferred in FP16
# we should not raise an Error here but instead show a warning
log.error("value '{}' of '{}' node exceeds FP16 limits: [{}, {}]. "
pavel-esir marked this conversation as resolved.
Show resolved Hide resolved
"This may lead to incorrect results of inference or may not be a problem, "
"depending on the model.".format(
val, node_name, np.finfo(np.float16).min, np.finfo(np.float16).max), extra={'is_warning': True})
# further this input values will be rewritten since force_shape_inference=True
node.in_port(i).data.set_value(val.astype(np.float16))
pavel-esir marked this conversation as resolved.
Show resolved Hide resolved

Expand Down
18 changes: 0 additions & 18 deletions model-optimizer/unit_tests/extensions/back/ChangeOutputTypeAttributes_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,31 +39,13 @@ def test_range_different_values(self):
graph, graph_ref = build_range_test_graphs(start=0, limit=50000, delta=1, dst_type_str='FP16')
self.assertRaises(Error, ChangeOutputTypeAttributes().find_and_replace_pattern, graph)

def test_range_out_of_fp16_max(self):
graph, graph_ref = build_range_test_graphs(start=0, limit=100000, delta=1, dst_type_str='FP16')
self.assertRaises(Error, ChangeOutputTypeAttributes().find_and_replace_pattern, graph)

def test_range_out_of_fp16_min(self):
graph, graph_ref = build_range_test_graphs(start=0, limit=-100000, delta=-1, dst_type_str='FP16')
self.assertRaises(Error, ChangeOutputTypeAttributes().find_and_replace_pattern, graph)

def test_cast_correct_case(self):
input_data = np.array([0, 1000, 4, 9, 0])
graph, graph_ref = build_cast_test_graphs(input_data, dst_type_str='FP16')
ChangeOutputTypeAttributes().find_and_replace_pattern(graph)
(flag, resp) = compare_graphs(graph, graph_ref, 'res', check_op_attrs=True)
self.assertTrue(flag, resp)

def test_cast_out_of_fp16_max(self):
input_data = np.array([0, 100000, 4, 9, 0])
graph, graph_ref = build_cast_test_graphs(input_data, dst_type_str='FP16')
self.assertRaises(Error, ChangeOutputTypeAttributes().find_and_replace_pattern, graph)

def test_cast_out_of_fp16_min(self):
input_data = np.array([0, -100000, 4, 9, 0])
graph, graph_ref = build_cast_test_graphs(input_data, dst_type_str='FP16')
self.assertRaises(Error, ChangeOutputTypeAttributes().find_and_replace_pattern, graph)


def build_range_test_graphs(start=0, limit=10, delta=1, dst_type_str='FP16',
src_type_str='FP32', returns_shape_value=None):
Expand Down