-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CPU] Added dynamism support for StridedSlice #8532
Merged
dmitry-gorokhov
merged 2 commits into
openvinotoolkit:master
from
a-sidorova:feature/dynamism/stridedslice/impl
Nov 17, 2021
Merged
[CPU] Added dynamism support for StridedSlice #8532
dmitry-gorokhov
merged 2 commits into
openvinotoolkit:master
from
a-sidorova:feature/dynamism/stridedslice/impl
Nov 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2efe0a6
to
9f02390
Compare
9f02390
to
c472440
Compare
c472440
to
3a5de2f
Compare
maxnick
requested changes
Nov 16, 2021
inference-engine/src/mkldnn_plugin/nodes/mkldnn_strided_slice_node.cpp
Outdated
Show resolved
Hide resolved
inference-engine/src/mkldnn_plugin/nodes/mkldnn_strided_slice_node.cpp
Outdated
Show resolved
Hide resolved
...gine/tests/functional/plugin/cpu/shared_tests_instances/single_layer_tests/strided_slice.cpp
Outdated
Show resolved
Hide resolved
inference-engine/src/mkldnn_plugin/nodes/mkldnn_strided_slice_node.h
Outdated
Show resolved
Hide resolved
inference-engine/src/mkldnn_plugin/nodes/mkldnn_strided_slice_node.h
Outdated
Show resolved
Hide resolved
maxnick
approved these changes
Nov 17, 2021
size_t dataSize = 1lu; | ||
} attrs; | ||
|
||
struct StridedSliceExecutor { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit. Since it has private fields, m.b. better to change into class.
dmitry-gorokhov
approved these changes
Nov 17, 2021
@dmitry-gorokhov validation is passed. DLB results are attached to the ticket. Looks good |
openvino-dev-samples
pushed a commit
to openvino-dev-samples/openvino
that referenced
this pull request
Nov 23, 2021
openvino-dev-samples
pushed a commit
to openvino-dev-samples/openvino
that referenced
this pull request
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: